Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add heights to every gRPC request #149

Open
3 tasks
colin-axner opened this issue Apr 29, 2021 · 6 comments · May be fixed by #7303
Open
3 tasks

Add heights to every gRPC request #149

colin-axner opened this issue Apr 29, 2021 · 6 comments · May be fixed by #7303
Labels
client-UX
Milestone
v11.0.0

Comments

@colin-axner
Copy link
Contributor

Summary

Heights are not included in gRPC requests as the height can be set in the SDK context. This isn't very useful for non-go implementations which might have a difficult time setting the SDK context correctly.

We should add a height request into the gRPC requests. ibc-rs is currently having difficulty doing gRPC requests at specific heights.

The height in the request seems sufficiently generalized that other implementations could implement the same gRPC routes with the same proto files

cc @fedekunze

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner
Copy link
Contributor Author

ref

@colin-axner colin-axner added this to the 1.0.1 milestone Apr 29, 2021
@colin-axner colin-axner self-assigned this May 26, 2021
@soareschen soareschen mentioned this issue Jun 4, 2021
Merged
5 tasks
@colin-axner colin-axner mentioned this issue Jul 12, 2021
Closed
9 tasks
@colin-axner colin-axner mentioned this issue Jul 21, 2021
Merged
9 tasks
@colin-axner colin-axner removed their assignment Aug 6, 2021
@crodriguezvega crodriguezvega modified the milestones: 1.1.0, vNext Sep 17, 2021
faddat referenced this issue in notional-labs/ibc-go Feb 23, 2022
@ethanfrey
Merge pull request #149 from CosmWasm/gas-for-each-instance
c1db37b 
Gas for each instance
@crodriguezvega crodriguezvega removed this from the Q2-2022-backlog milestone Mar 31, 2022
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@Raneet10
Add batching for KVstore (cosmos#149)
42da76f 
* add batching to KVStore
* add batch for PrefixKV
@noot
Copy link

noot commented Jan 18, 2024

@colin-axner any progress/updates on this? I'm working on integrating IBC in Rust into Astria and have run into this as a major issue, since I would rather use only gRPC requests rather than the ABCI + gRPC combo. I'm happy to take this issue on!

@DimitrisJim
Copy link
Contributor

doesn't appear that this was closed due to some blocker so don't see why you couldn't take it on and push it through, rationale still appears to hold 😄. cc @crodriguezvega for a second opinion.

@crodriguezvega
Copy link
Contributor

No, this hasn't been implemented and there hasn't been any progress, so thanks @noot if you want to work on it. For reference, here's a PR where Colin started to work on this but eventually closed.

@noot
Copy link

noot commented Jan 19, 2024

great, thanks @DimitrisJim and @crodriguezvega ! I'll take this on then :)

@noot noot mentioned this issue Jan 22, 2024
Closed
9 tasks
@coderabbitai coderabbitai bot mentioned this issue Apr 21, 2024
Merged
12 tasks
@crodriguezvega
Copy link
Contributor

I am going to tentatively put this in v11...

@crodriguezvega crodriguezvega added this to the v11.0.0 milestone Aug 15, 2024
@noot noot linked a pull request Sep 17, 2024 that will close this issue
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
client-UX
Projects
ibc-go
Status: Todo 🏃
Milestone
v11.0.0
4 participants
@crodriguezvega @DimitrisJim @colin-axner @noot