{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":362803895,"defaultBranch":"master","name":"rook","ownerLogin":"criteo-forks","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2021-04-29T12:07:29.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/9960514?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1726238935.0","currentOid":""},"activityList":{"items":[{"before":null,"after":"843971666172753c2f4ed617383316a0cf77a063","ref":"refs/heads/LAKE-16118","pushedAt":"2024-09-13T14:48:55.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Willymontaz","name":"William Montaz","path":"/Willymontaz","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/170889?s=80&v=4"},"commit":{"message":"[CRITEO] Allow to use a dedicated service account for RGW\n\nTo achieve so, one must add an annotation in CephObjectStore \"crto.in/rook-custom-service-account\"\n\nLAKE-16118","shortMessageHtmlLink":"[CRITEO] Allow to use a dedicated service account for RGW"}},{"before":"6645cd5cea6189afa18ecaf34d36a05569d83d03","after":"a38ea67c97ee0d8fbc2fe03c81e260851e681362","ref":"refs/heads/1.12.11-criteo","pushedAt":"2024-05-13T15:51:39.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"jlcCriteo","name":null,"path":"/jlcCriteo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/133649774?s=80&v=4"},"commit":{"message":"Avoid conflict when deploying one operator per namespace (#16)","shortMessageHtmlLink":"Avoid conflict when deploying one operator per namespace (#16)"}},{"before":null,"after":"6645cd5cea6189afa18ecaf34d36a05569d83d03","ref":"refs/heads/1.12.11-criteo","pushedAt":"2024-04-11T14:10:59.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jlcCriteo","name":null,"path":"/jlcCriteo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/133649774?s=80&v=4"},"commit":{"message":"Rook operator needs Go 1.20|1.21","shortMessageHtmlLink":"Rook operator needs Go 1.20|1.21"}},{"before":"76dfbd779fccbe624e859167c410490577d22e95","after":null,"ref":"refs/heads/1.12.9-criteo","pushedAt":"2024-04-11T13:58:12.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jlcCriteo","name":null,"path":"/jlcCriteo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/133649774?s=80&v=4"}},{"before":null,"after":"baa922cb12ec43c3e0f29d0d304913cb8452f454","ref":"refs/heads/1.11.11-criteo","pushedAt":"2024-04-11T13:58:09.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jlcCriteo","name":null,"path":"/jlcCriteo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/133649774?s=80&v=4"},"commit":{"message":"Avoid conflict when deploying one operator per namespace (#15)","shortMessageHtmlLink":"Avoid conflict when deploying one operator per namespace (#15)"}},{"before":"baa922cb12ec43c3e0f29d0d304913cb8452f454","after":null,"ref":"refs/heads/1.11.11-criteo","pushedAt":"2024-04-11T13:58:05.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jlcCriteo","name":null,"path":"/jlcCriteo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/133649774?s=80&v=4"}},{"before":"76dfbd779fccbe624e859167c410490577d22e95","after":null,"ref":"refs/tags/v1.12.9-criteo1","pushedAt":"2024-04-11T13:57:44.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jlcCriteo","name":null,"path":"/jlcCriteo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/133649774?s=80&v=4"}},{"before":null,"after":"76dfbd779fccbe624e859167c410490577d22e95","ref":"refs/heads/1.12.9-criteo","pushedAt":"2024-04-05T16:04:04.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jlcCriteo","name":null,"path":"/jlcCriteo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/133649774?s=80&v=4"},"commit":{"message":"Avoid conflict when deploying one operator per namespace (#15)","shortMessageHtmlLink":"Avoid conflict when deploying one operator per namespace (#15)"}},{"before":"58c9b596badf2a0e473fab8b0e6f41562852a96e","after":"baa922cb12ec43c3e0f29d0d304913cb8452f454","ref":"refs/heads/1.11.11-criteo","pushedAt":"2024-03-26T08:33:39.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"jlcCriteo","name":null,"path":"/jlcCriteo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/133649774?s=80&v=4"},"commit":{"message":"Avoid conflict when deploying one operator per namespace (#15)","shortMessageHtmlLink":"Avoid conflict when deploying one operator per namespace (#15)"}},{"before":"269a5e298c8b484babbb94c0d9b018490de45cd2","after":"58c9b596badf2a0e473fab8b0e6f41562852a96e","ref":"refs/heads/1.11.11-criteo","pushedAt":"2024-03-01T12:12:02.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"jlcCriteo","name":null,"path":"/jlcCriteo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/133649774?s=80&v=4"},"commit":{"message":"avoid naming conflicts on rbac when deploying one operator per namespace\n\n[Candidate for upstream]\n\nWhen deploying multiple ceph clusters on single kubernetes cluster (for\nmulti-tenancy for example), we can opt for deploying one operator per\nnamespace thanks to currentNamespaceOnly helm variable. Unfortunately we\nare facing conflicts on ClusterRole/ClusterRoleBinding when deploying\nrook-ceph helm chart in distinct namespaces.\n\nThis commit adds namespace suffix to ClusterRole/ClusterRoleBinding when\ndeploying operator with currentNamespaceOnly=true","shortMessageHtmlLink":"avoid naming conflicts on rbac when deploying one operator per namespace"}},{"before":null,"after":"269a5e298c8b484babbb94c0d9b018490de45cd2","ref":"refs/heads/1.11.11-criteo","pushedAt":"2024-02-27T13:20:03.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jlcCriteo","name":null,"path":"/jlcCriteo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/133649774?s=80&v=4"},"commit":{"message":"pool: manage pg_num_min and pg_num_max parameters (#11, #12)\n\nWhile it is possible to set these parameters through pool spec\n(see setCommonPoolProperties), the current approach is too\nsimple to be practical.\n\nCeph requires pg_num/pgp_num to be consistent with new pg_num_min\nand pg_num_max values before accepting to change them.\nLet's say you want to create a particular rgw index pool with a minimum\nof 32 PG instead of 8 PG by default, and still want to have pg autoscaler\nenabled to handle future growth.\n* index pool will be created with 8 PG by default\n* if then you try to set pg_num_min parameter via pool spec, set call will\nfail due to pg_num < new pg_num_min.\n* if you try to set pg_num/pgp_num/pg_num_min parameters via pool spec,\nset calls will fail too because you don't control the order in which\nparameters are applied (Parameters is a map with no particular ordering\nwhen setCommonPoolProperties iterates over parameters)\n* even if above point would be properly managed, set calls could still\nfail if pg autoscaler kick-in between setting of pg_num/pgp_num parameters\nand setting of pp_num_min parameter.\n\nThis commit makes pg_num_min/pg_num_max pool parameters fully managed\nby rook, handling rescaling of number of PG if needed, and including\nsuspend of pg_autoscaler during PG rescaling.\n\nCo-authored-by: Peter Goron ","shortMessageHtmlLink":"pool: manage pg_num_min and pg_num_max parameters (#11, #12)"}},{"before":"a70bca3d50c7bfd8b0a2392560458036f85139cd","after":"465a7e33da6ab00f91c65ade90030073dcae87b5","ref":"refs/heads/1.10.13-criteo","pushedAt":"2023-09-04T07:37:54.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"pgoron","name":"Peter Goron","path":"/pgoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/386179?s=80&v=4"},"commit":{"message":"avoid naming conflicts on rbac when deploying one operator per namespace\n\n[Candidate for upstream]\n\nWhen deploying multiple ceph clusters on single kubernetes cluster (for\nmulti-tenancy for example), we can opt for deploying one operator per\nnamespace thanks to currentNamespaceOnly helm variable. Unfortunately we\nare facing conflicts on ClusterRole/ClusterRoleBinding when deploying\nrook-ceph helm chart in distinct namespaces.\n\nThis commit adds namespace suffix to ClusterRole/ClusterRoleBinding when\ndeploying operator with currentNamespaceOnly=true","shortMessageHtmlLink":"avoid naming conflicts on rbac when deploying one operator per namespace"}},{"before":"fe3623997abe3a7d7d15b382562116b3e15d183e","after":"a70bca3d50c7bfd8b0a2392560458036f85139cd","ref":"refs/heads/1.10.13-criteo","pushedAt":"2023-08-18T12:05:26.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"pgoron","name":"Peter Goron","path":"/pgoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/386179?s=80&v=4"},"commit":{"message":"user: fix typo preventing creation of users caps (#13)\n\nIssue introduced by https://github.com/criteo-forks/rook/commit/f91e794c4dc3f6ecbd2a0ebb2dc5f5c045fc8179\r\n\r\nBut fixed before submission to upstream\r\nhttps://github.com/rook/rook/pull/12460/files\r\n\r\nCo-authored-by: Peter Goron ","shortMessageHtmlLink":"user: fix typo preventing creation of users caps (#13)"}},{"before":"891a1a12934811e82e55182b441c464115391fbf","after":"fe3623997abe3a7d7d15b382562116b3e15d183e","ref":"refs/heads/1.10.13-criteo","pushedAt":"2023-08-18T09:00:19.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"pgoron","name":"Peter Goron","path":"/pgoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/386179?s=80&v=4"},"commit":{"message":"pool: fix multiple bugs on setPgNumMinMaxProperties (#12)\n\nunit test coverage extended\r\n\r\nCo-authored-by: Peter Goron ","shortMessageHtmlLink":"pool: fix multiple bugs on setPgNumMinMaxProperties (#12)"}},{"before":"e9a0d17924efd7a1002c72c96575a97bb22a0811","after":"891a1a12934811e82e55182b441c464115391fbf","ref":"refs/heads/1.10.13-criteo","pushedAt":"2023-08-14T08:26:50.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"pgoron","name":"Peter Goron","path":"/pgoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/386179?s=80&v=4"},"commit":{"message":"pool: manage pg_num_min and pg_num_max parameters (#11)\n\nWhile it is possible to set these parameters through pool spec\r\n(see setCommonPoolProperties), the current approach is too\r\nsimple to be practical.\r\n\r\nCeph requires pg_num/pgp_num to be consistent with new pg_num_min\r\nand pg_num_max values before accepting to change them.\r\nLet's say you want to create a particular rgw index pool with a minimum\r\nof 32 PG instead of 8 PG by default, and still want to have pg autoscaler\r\nenabled to handle future growth.\r\n* index pool will be created with 8 PG by default\r\n* if then you try to set pg_num_min parameter via pool spec, set call will\r\nfail due to pg_num < new pg_num_min.\r\n* if you try to set pg_num/pgp_num/pg_num_min parameters via pool spec,\r\nset calls will fail too because you don't control the order in which\r\nparameters are applied (Parameters is a map with no particular ordering\r\nwhen setCommonPoolProperties iterates over parameters)\r\n* even if above point would be properly managed, set calls could still\r\nfail if pg autoscaler kick-in between setting of pg_num/pgp_num parameters\r\nand setting of pp_num_min parameter.\r\n\r\nThis commit makes pg_num_min/pg_num_max pool parameters fully managed\r\nby rook, handling rescaling of number of PG if needed, and including\r\nsuspend of pg_autoscaler during PG rescaling.\r\n\r\nCo-authored-by: Peter Goron ","shortMessageHtmlLink":"pool: manage pg_num_min and pg_num_max parameters (#11)"}},{"before":"f91e794c4dc3f6ecbd2a0ebb2dc5f5c045fc8179","after":"71c23e1e2453dec75aba655cb0e8f75fe566ce68","ref":"refs/heads/1.9.12-criteo","pushedAt":"2023-06-20T16:34:41.046Z","pushType":"push","commitsCount":1,"pusher":{"login":"pgoron","name":"Peter Goron","path":"/pgoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/386179?s=80&v=4"},"commit":{"message":"ubuntu-18.04 runner not more provided by github","shortMessageHtmlLink":"ubuntu-18.04 runner not more provided by github"}},{"before":"02ee0b97d0b4b19b9f0987c818f4259d8cfeff89","after":"e9a0d17924efd7a1002c72c96575a97bb22a0811","ref":"refs/heads/1.10.13-criteo","pushedAt":"2023-06-20T16:30:52.364Z","pushType":"push","commitsCount":1,"pusher":{"login":"pgoron","name":"Peter Goron","path":"/pgoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/386179?s=80&v=4"},"commit":{"message":"fix missing admin capabilities for cephobjectstoreusers\n\nusers and buckets admin capabilities are supported by ceph (see\nhttps://github.com/ceph/ceph/blob/main/src/rgw/rgw_common.cc#L2093)\nbut are discarded by rook/kubernetes because they aren't part\nof the CRD.","shortMessageHtmlLink":"fix missing admin capabilities for cephobjectstoreusers"}},{"before":"87254ddbd2a09b8fd6839da5bc2ae501b04f1817","after":"f91e794c4dc3f6ecbd2a0ebb2dc5f5c045fc8179","ref":"refs/heads/1.9.12-criteo","pushedAt":"2023-06-20T16:23:33.209Z","pushType":"push","commitsCount":1,"pusher":{"login":"pgoron","name":"Peter Goron","path":"/pgoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/386179?s=80&v=4"},"commit":{"message":"fix missing admin capabilities for cephobjectstoreusers\n\nusers and buckets admin capabilities are supported by ceph (see\nhttps://github.com/ceph/ceph/blob/main/src/rgw/rgw_common.cc#L2093)\nbut are discarded by rook/kubernetes because they aren't part\nof the CRD.","shortMessageHtmlLink":"fix missing admin capabilities for cephobjectstoreusers"}},{"before":"bc40db93d0d5e7d70f93f6c7744fa7619f7b598f","after":"02ee0b97d0b4b19b9f0987c818f4259d8cfeff89","ref":"refs/heads/1.10.13-criteo","pushedAt":"2023-06-18T09:03:25.170Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"pgoron","name":"Peter Goron","path":"/pgoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/386179?s=80&v=4"},"commit":{"message":"add a variable to enable cluster-wide objects deployment\n\nAt Criteo, we deploy one operator per cluster/namespace.\nWith Helm, we can't have multiple helm releases that\ndeploy same non-namespaced objects (ClusterRole /\nClusterRoleBinding)","shortMessageHtmlLink":"add a variable to enable cluster-wide objects deployment"}},{"before":"bc40db93d0d5e7d70f93f6c7744fa7619f7b598f","after":null,"ref":"refs/tags/v1.10.13-criteo1","pushedAt":"2023-06-18T09:01:37.934Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"pgoron","name":"Peter Goron","path":"/pgoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/386179?s=80&v=4"}},{"before":"85d4fc21be530d6354a040020c69380098925942","after":"bc40db93d0d5e7d70f93f6c7744fa7619f7b598f","ref":"refs/heads/1.10.13-criteo","pushedAt":"2023-06-18T08:52:40.430Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"pgoron","name":"Peter Goron","path":"/pgoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/386179?s=80&v=4"},"commit":{"message":"add a variable to enable cluster-wide objects deployment\n\nAt Criteo, we deploy one operator per cluster/namespace.\nWith Helm, we can't have multiple helm releases that\ndeploy same non-namespaced objects (ClusterRole /\nClusterRoleBinding)","shortMessageHtmlLink":"add a variable to enable cluster-wide objects deployment"}},{"before":"c8c86902c2dd5e842e1dbea88ce9dff6be478a44","after":null,"ref":"refs/tags/v1.10.13-criteo1","pushedAt":"2023-06-18T08:51:40.995Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"pgoron","name":"Peter Goron","path":"/pgoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/386179?s=80&v=4"}},{"before":"85d4fc21be530d6354a040020c69380098925942","after":null,"ref":"refs/tags/v1.10.13-criteo2","pushedAt":"2023-06-18T08:51:33.823Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"pgoron","name":"Peter Goron","path":"/pgoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/386179?s=80&v=4"}},{"before":"c8c86902c2dd5e842e1dbea88ce9dff6be478a44","after":"85d4fc21be530d6354a040020c69380098925942","ref":"refs/heads/1.10.13-criteo","pushedAt":"2023-06-18T08:40:47.574Z","pushType":"push","commitsCount":1,"pusher":{"login":"pgoron","name":"Peter Goron","path":"/pgoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/386179?s=80&v=4"},"commit":{"message":"fix github action being triggered too many times","shortMessageHtmlLink":"fix github action being triggered too many times"}},{"before":null,"after":"c8c86902c2dd5e842e1dbea88ce9dff6be478a44","ref":"refs/heads/1.10.13-criteo","pushedAt":"2023-06-17T14:32:40.060Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"pgoron","name":"Peter Goron","path":"/pgoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/386179?s=80&v=4"},"commit":{"message":"add a variable to enable cluster-wide objects deployment\n\nAt Criteo, we deploy one operator per cluster/namespace.\nWith Helm, we can't have multiple helm releases that\ndeploy same non-namespaced objects (ClusterRole /\nClusterRoleBinding)","shortMessageHtmlLink":"add a variable to enable cluster-wide objects deployment"}},{"before":"28ff31b3e512bad8a7c33e5925f655f9ade778d2","after":"87254ddbd2a09b8fd6839da5bc2ae501b04f1817","ref":"refs/heads/1.9.12-criteo","pushedAt":"2023-06-17T14:13:47.752Z","pushType":"push","commitsCount":1,"pusher":{"login":"pgoron","name":"Peter Goron","path":"/pgoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/386179?s=80&v=4"},"commit":{"message":"add a variable to enable cluster-wide objects deployment\n\nAt Criteo, we deploy one operator per cluster/namespace.\nWith Helm, we can't have multiple helm releases that\ndeploy same non-namespaced objects (ClusterRole /\nClusterRoleBinding)","shortMessageHtmlLink":"add a variable to enable cluster-wide objects deployment"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xM1QxNDo0ODo1NS4wMDAwMDBazwAAAAS1mZxh","startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xM1QxNDo0ODo1NS4wMDAwMDBazwAAAAS1mZxh","endCursor":"Y3Vyc29yOnYyOpK7MjAyMy0wNi0xN1QxNDoxMzo0Ny43NTIyMDRazwAAAANDjtxL"}},"title":"Activity ยท criteo-forks/rook"}