Create a webhook for volumereplication and volumereplicationclass #90

iamniting · 2021-06-24T08:50:50Z

Signed-off-by: Nitin Goyal [email protected]

operator-sdk alpha config-3alpha-to-3 WARN[0000] Config version 3-alpha has been stabilized as 3, and 3-alpha is no longer supported. Run `operator-sdk alpha config-3alpha-to-3` to upgrade your PROJECT config file to version 3 Signed-off-by: Nitin Goyal <[email protected]>

operator-sdk create webhook --group replication --version v1alpha1 \ --kind VolumeReplication --programmatic-validation --defaulting Signed-off-by: Nitin Goyal <[email protected]>

iamniting · 2021-06-24T08:51:35Z

I have not tested this yet. Will give it a shot.

Madhu-1 · 2021-06-24T08:53:39Z

Please provide the logs and output once you finish with the testing.

iamniting · 2021-06-30T07:41:55Z

VRC webhook results when I am trying to change anything in the spec

$ oc edit vrc vrc 
error: volumereplicationclasses.replication.storage.openshift.io "vrc" could not be patched: admission webhook "vvolumereplicationclass.kb.io" denied the request: Spec.Provisioner is immutable
You can run `oc replace -f /tmp/oc-edit-cb67t.yaml` to try this update again.

$ oc edit vrc vrc 
error: volumereplicationclasses.replication.storage.openshift.io "vrc" could not be patched: admission webhook "vvolumereplicationclass.kb.io" denied the request: Spec.Parameters is immutable
You can run `oc replace -f /tmp/oc-edit-0brft.yaml` to try this update again.

Signed-off-by: Nitin Goyal <[email protected]>

operator-sdk create webhook --group replication --version v1alpha1 \ --kind VolumeReplicationClass --programmatic-validation --defaulting Signed-off-by: Nitin Goyal <[email protected]>

Signed-off-by: Nitin Goyal <[email protected]>

iamniting · 2021-06-30T08:45:19Z

VR webhook is not working as expected as of now will debug and update

$ oc edit vr vr1
error: volumereplications.replication.storage.openshift.io "vr1" could not be patched: Internal error occurred: failed calling webhook "mvolumereplication.kb.io": webhook returned response.patchType but not response.patch
You can run `oc replace -f /tmp/oc-edit-3uojs.yaml` to try this update again.

iamniting · 2021-07-05T09:57:33Z

VR webhook is not working as expected as of now will debug and update

$ oc edit vr vr1
error: volumereplications.replication.storage.openshift.io "vr1" could not be patched: Internal error occurred: failed calling webhook "mvolumereplication.kb.io": webhook returned response.patchType but not response.patch
You can run `oc replace -f /tmp/oc-edit-3uojs.yaml` to try this update again.

Let me try this if it works operator-framework/operator-sdk#4602

iamniting · 2021-07-05T10:05:39Z

Finally VR webhook is also working

$ oc edit vr vr1
error: volumereplications.replication.storage.openshift.io "vr1" could not be patched: admission webhook "vvolumereplication.kb.io" denied the request: Spec.DataSource is immutable
You can run `oc replace -f /tmp/oc-edit-3nzi3.yaml` to try this update again.

$ oc edit vr vr1
error: volumereplications.replication.storage.openshift.io "vr1" could not be patched: admission webhook "vvolumereplication.kb.io" denied the request: Spec.VolumeReplicationClass is immutable
You can run `oc replace -f /tmp/oc-edit-vuh8i.yaml` to try this update again.

resolve: operator-framework/operator-sdk#4602 Signed-off-by: Nitin Goyal <[email protected]>

Signed-off-by: Nitin Goyal <[email protected]>

umangachapagain

Update PROJECT config for 3alpha to 3 commit should be a separate PR as it is not specific to webhooks. This will help us track changes through PRs easily.

VolumeReplication webhook scaffold and implementation should be a single commit. Same for VolumeReplicationClass webhook scaffold and implementation.

Controller runtime update should be a separate PR. Sometimes it has breaking changes which needs explicit communication.

umangachapagain · 2021-07-05T10:28:47Z

.github/workflows/golangci-lint.yaml

-        # TODO: remove --skip-files controllers/suite_test.go once logic is implemented
-        args: -E gosec --timeout=6m --skip-files controllers/suite_test.go
+        # TODO: remove --skip-files controllers/suite_test.go api/v1alpha1/webhook_suite_test.go once logic is implemented
+        args: -E gosec --timeout=6m --skip-files controllers/suite_test.go,api/v1alpha1/webhook_suite_test.go


Why are we skipping tests instead of implementing it? At the every least we need to mark it as TODO and create a tracker issue.

It already a TODO to remove these skip-files once we implement tests. We can create a issue.

iamniting · 2021-07-05T10:38:46Z

Update PROJECT config for 3alpha to 3 commit should be a separate PR as it is not specific to webhooks. This will help us track changes through PRs easily.

This can be done. I faced this issue while creating scafolding for webhook that's why updated in this one itself

VolumeReplication webhook scaffold and implementation should be a single commit. Same for VolumeReplicationClass webhook scaffold and implementation.

I would like to keep them as separate commits. It makes life easy to distinguish b/w generated code and implemented logic.

Controller runtime update should be a separate PR. Sometimes it has breaking changes which needs explicit communication.

I still think that we should send with this PR itself, because new controller runtime has a fix for webhook itself.

iamniting · 2021-07-05T11:15:05Z

How to test:
once you have a working setup

change the image to CSI_VOLUME_REPLICATION_IMAGE: quay.io/nigoyal/volumereplication-operator:webhook
kubectl edit configmaps rook-ceph-operator-config

create a cert manager
kubectl apply -f https://github.com/jetstack/cert-manager/releases/download/v1.4.0/cert-manager.yaml

create certies, required service etc
kubectl apply -f https://raw.githubusercontent.com/iamniting/conf/master/k8s/vr/webhook-conf.yaml --validate=false

now you can test the webhook functionality

mergify · 2021-08-25T05:45:35Z

This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏

iamniting · 2022-12-08T09:34:05Z

Closing this PR as it is not required anymore.

iamniting added 2 commits June 24, 2021 12:28

Create webhook scafold for VolumeReplication

3199937

operator-sdk create webhook --group replication --version v1alpha1 \ --kind VolumeReplication --programmatic-validation --defaulting Signed-off-by: Nitin Goyal <[email protected]>

iamniting requested review from sp98 and Madhu-1 June 24, 2021 08:51

Madhu-1 added the DNM Do not merge label Jun 24, 2021

iamniting force-pushed the webhook branch from 2a219d7 to ad6f0b8 Compare June 30, 2021 08:38

iamniting added 4 commits June 30, 2021 14:13

Implement volumereplication webhook

2f7a937

Signed-off-by: Nitin Goyal <[email protected]>

Create webhook scafold for VolumeReplicationClass

861638c

operator-sdk create webhook --group replication --version v1alpha1 \ --kind VolumeReplicationClass --programmatic-validation --defaulting Signed-off-by: Nitin Goyal <[email protected]>

Implement volumereplicationclass webhook

477912e

Signed-off-by: Nitin Goyal <[email protected]>

actions: skip api/v1alpha1/webhook_suite_test.go in golangci-lint

bbb19b9

Signed-off-by: Nitin Goyal <[email protected]>

iamniting force-pushed the webhook branch from ad6f0b8 to bbb19b9 Compare June 30, 2021 08:44

iamniting added 2 commits July 5, 2021 15:36

godeps: Update controller runtime to v0.7.2

011e5fd

resolve: operator-framework/operator-sdk#4602 Signed-off-by: Nitin Goyal <[email protected]>

Add files generated by make manifests generate

fcc8c85

Signed-off-by: Nitin Goyal <[email protected]>

umangachapagain requested changes Jul 5, 2021

View reviewed changes

umangachapagain reviewed Jul 5, 2021

View reviewed changes

iamniting requested a review from umangachapagain July 5, 2021 10:40

iamniting closed this Dec 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create a webhook for volumereplication and volumereplicationclass #90

Create a webhook for volumereplication and volumereplicationclass #90

iamniting commented Jun 24, 2021

iamniting commented Jun 24, 2021

Madhu-1 commented Jun 24, 2021

iamniting commented Jun 30, 2021

iamniting commented Jun 30, 2021

iamniting commented Jul 5, 2021

iamniting commented Jul 5, 2021

umangachapagain left a comment

umangachapagain Jul 5, 2021

iamniting Jul 5, 2021

iamniting commented Jul 5, 2021 •

edited

Loading

iamniting commented Jul 5, 2021 •

edited

Loading

mergify bot commented Aug 25, 2021

iamniting commented Dec 8, 2022

Create a webhook for volumereplication and volumereplicationclass #90

Create a webhook for volumereplication and volumereplicationclass #90

Conversation

iamniting commented Jun 24, 2021

iamniting commented Jun 24, 2021

Madhu-1 commented Jun 24, 2021

iamniting commented Jun 30, 2021

iamniting commented Jun 30, 2021

iamniting commented Jul 5, 2021

iamniting commented Jul 5, 2021

umangachapagain left a comment

Choose a reason for hiding this comment

umangachapagain Jul 5, 2021

Choose a reason for hiding this comment

iamniting Jul 5, 2021

Choose a reason for hiding this comment

iamniting commented Jul 5, 2021 • edited Loading

iamniting commented Jul 5, 2021 • edited Loading

mergify bot commented Aug 25, 2021

iamniting commented Dec 8, 2022

iamniting commented Jul 5, 2021 •

edited

Loading

iamniting commented Jul 5, 2021 •

edited

Loading