Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github:// urls - proper error message when a target repository or branch doesn't exist #180

Open
peteruhnak opened this issue Mar 25, 2016 · 2 comments

Comments

@peteruhnak
Copy link

Currently when I type in incorrect name of repo or a branch I just get a weird error saying that a zip wasn't found.

este

This is very cryptic when one encounters it for the first time. Why it shows error only when attempted to load the zip, and not during the download? Why did the download failed silently?

Ideally it could also tell what part is incorrect, e.g. good repo, but branch doesn't exist… but that would be probably unnecessarily complex.

@ThierryGoubier
Copy link
Collaborator

The code for handling github:// urls is in Metacello, not FileTree. Error detection and analysis is dependent on what the github API returns

@ThierryGoubier
Copy link
Collaborator

I'll also rename the issue, because it has nothing to do with GitFileTree :)

@ThierryGoubier ThierryGoubier changed the title GitFileTree - proper error message when a target repository or branch doesn't exist github:// urls - proper error message when a target repository or branch doesn't exist Mar 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants