Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter_tools] flutter build apk --release runs logic to discover packages with hooks 7 times #1550

Open
mkustermann opened this issue Sep 11, 2024 · 0 comments

Comments

@mkustermann
Copy link
Member

Ideally the code would be structured in a way that allows any tool to discover transitive package graph (and the subset thereof that has hooks in it) once. Then any following action can operate on that knowledge.

Though it seems a flutter build apk --release is currently triggering the logic that discovers all packages (namely PackageLayout._packagesWithHook) 7 times. This seems wasteful.

(Filing this here even though the corresponding code may be in flutter tools)

/cc @dcharkes

@dcharkes dcharkes changed the title flutter build apk --release runs logic to discover packages with hooks 7 times [flutter_tools] flutter build apk --release runs logic to discover packages with hooks 7 times Sep 11, 2024
@dcharkes dcharkes added this to the Native Assets v1.x milestone Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants