Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not sure how to do testing for the static dataset #16

Open
beckynevin opened this issue Feb 2, 2024 · 6 comments
Open

Not sure how to do testing for the static dataset #16

beckynevin opened this issue Feb 2, 2024 · 6 comments
Labels
question Further information is requested

Comments

@beckynevin
Copy link
Collaborator

Might be better to use the workflow to run this in a docker container that we add data files to.

@bnord
Copy link
Contributor

bnord commented Jun 5, 2024

Is this same as or contained in #47 ?

@bnord
Copy link
Contributor

bnord commented Jun 5, 2024

@beckynevin @voetberg sorry, I meant to tag usernames

@voetberg
Copy link
Contributor

voetberg commented Jun 6, 2024

@bnord No, I think this is different. This issue (I think!) is referring to the dataset without a simulator. Related issue is #48

@bnord
Copy link
Contributor

bnord commented Jun 6, 2024

should we ship this package with a small data set attached to allow for testing?

I'm not sure how the docker thing would work, other than also attaching a docker file to this repo, which seems like it would be a larger file than a small data file.

@voetberg
Copy link
Contributor

voetberg commented Jun 6, 2024

There is a dataset and model included for testing (in resources/saveddata). Not sure what you mean by shipping the package with it though.

@bnord
Copy link
Contributor

bnord commented Jun 6, 2024

I just meant including it in the repo and the pypi package. I'm not sure how common it is to include a data set in those when you release a version.

@voetberg voetberg added the question Further information is requested label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants