Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable Reuse via global var store #45

Open
voetberg opened this issue Mar 28, 2024 · 6 comments
Open

Variable Reuse via global var store #45

voetberg opened this issue Mar 28, 2024 · 6 comments
Labels
enhancement New feature or request Wishlist

Comments

@voetberg
Copy link
Contributor

Certainly metrics will use the same data/inference over and over again. The modular approach in PR #43 will mean that calculations are probably going to be replicated.

Should we implement some sort of global variable store (something akin to a light-weight sql db) to avoid repeat work?

@voetberg voetberg added Wishlist enhancement New feature or request labels Mar 28, 2024
@voetberg
Copy link
Contributor Author

Shelve Probably does what we need. Some care will need to be taken to make sure everything is serializable but that's not a huge barrier.

@bnord
Copy link
Contributor

bnord commented Mar 29, 2024

I suspect that global variable usage will be low risk in this app because people won't be using this with new variables to write new code. they'll just be hitting go and get things out of it.

@bnord
Copy link
Contributor

bnord commented Mar 29, 2024

shelf (as a dictionary-like thing) looks better (less complicated?) than a db.

@bnord
Copy link
Contributor

bnord commented Mar 29, 2024

I think the only variables that people may want to change will be plot formatting parameters; maybe those shouldn't be globalized?

@voetberg
Copy link
Contributor Author

I was thinking more about how calculating metrics would be horribly inefficient to re-do for multiple calculations. So storing them in that shelf-like lookup table would help reduce redundancy internally, the users wouldn't interact with it at all.

@bnord
Copy link
Contributor

bnord commented May 6, 2024

agree. the shelf dilly looks baller.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Wishlist
Projects
None yet
Development

No branches or pull requests

2 participants