Skip to content
This repository has been archived by the owner on Sep 1, 2020. It is now read-only.

Usage of Wire library. #18

Open
Koepel opened this issue Mar 23, 2019 · 1 comment
Open

Usage of Wire library. #18

Koepel opened this issue Mar 23, 2019 · 1 comment

Comments

@Koepel
Copy link

Koepel commented Mar 23, 2019

In the file "APDS9930/src/APDS9930.cpp", the function "wireWriteDataBlock()" is not used, but it contains a bug.

The sequence should be: beginTransmission - write - write - write - endTransmission
However, instead of writing data, both Wire.beginTransmission() and Wire.write() are called (multiple) times.
The extra Wire.beginTransmission() is at the moment in line 1082. That line may be removed.

A similar issue is in the original code from Sparkfun.

@depau
Copy link
Owner

depau commented Apr 11, 2019

Please send a pull request and I'll review it :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants