RecurringEvents.iter_after() not producing correct results

[JoeyStk]

Describe the Bug

The recurrence rule in #3018 is (still) broken for iter_after(). As long as this is not resolved, our release is blocked

Steps to Reproduce

1. Start your dev server, go to events
2. (delete any existing events if you want to make step 5 easier)
3. Create a new event, set as recurrence rule every last Thursday starting in August (every month, last week, Thursday, every 1st...)
4. In your browser, go to the path f"/api/v3/{region_slug}/{language_slug}/events/" of your running dev server
5. See that for every month the 29th is returned

Expected Behavior

Show for an event that happens every last Thursday the list of last Thursdays (so August 29th, September 26th, October 31st, November 28th, etc.).

Actual Behavior

(1) The current state on production is that only August 29th, October 31st and January are shown (months that have a fifth week). (2) #2992 attempted to fix this, but on the test system now the 29th of a month is shown.

Additional Information

App screenshot from the test system (potentially showing a different bug in the app)

State on production, before #2992
State after #2992

Both are not what we expect

[PeterNerlich]

On a side note, I think the way we implement and display monthly recurrence for a weekday is misleading. We display First/Second/Third/Last Week, but we actually mean the nth occurrence of that weekday in the month. (I would expect the month to be segmented into weeks from weekend to weekend and the counting be based on that with what we current show – but the start of those equivalency groups is actually based on which weekday the month starts or ends on)

[PeterNerlich]

Ah, #2992 misunderstood the original issue #2989 for an invalid rendering of the iCal format, a bug they likely determined to be the intended target because of the difficulties of identifying the part of the CMS where the event data is handed over to the app (navigating from the function implementing the generation of event instances to our actual API endpoint exposing it proved confusing, even if it was not the worst one I encountered so far in this project).
I decided to change how we store and handle the intention of "last occurrence in month", rendering the functional changes of #2992 unnecessary, but it should be closer to how iCal does it and be less ambiguous (using negative values to count from the end of the month instead of the start)

[david-venhoff]

I think this issue is invalid:
The test 5 Woche event is set to reccur every 3rd week (contradicting the title), if this is the correct event that is shown in the screenshot: https://cms-test.integreat-app.de/muenchen/events/de/4599/edit/

However, that still does not explain the dates listed at https://webnext.integreat.app/muenchen/de/events/test-5-woche ^^

That appears to be an app issue though, because we pass the correct recurrence rule to it, as can be seen in the network manager in the browser devtools of the page. Here is the relevant snippet:

As can be seen, the recurrence rule is correctly set to repeat every third week of the month.

Because the combine_recurring parameter is set, our iter_after function never gets called even if it is technically incorrect right now.

[david-venhoff]

I think the bug is that the frontend somehow ignores the byday completely. To reproduce:

1. open https://webnext.integreat.app/testumgebung/de/events/test-monthly
2. Open your browser devtools and inspect the request to cms-test.integreat-app.de/api/v3/testumgebung/de/events/?combine_recurring=True
3. See the the recurrence rule is DTSTART:20240827T220000RRULE:FREQ=MONTHLY;BYDAY=-1WE, which is correct
4. Click on export as ical (Als ical exportieren)
5. Select Diese und alle zukünftigen Veranstaltungen
6. open the file in a text editor and see the the recurrence rule is missing the BYDAY parameter, which explains the listed dates in the frontend: RRULE:FREQ=MONTHLY;INTERVAL=1

[PeterNerlich]

Are we positive that the app only uses the endpoint with ?combine_recurring=True?

[david-venhoff]

I am pretty sure that we currently use the endpoint with this flag only, at least for the the event pages (As can be seen in the browser devtools). I also had a call with Leandra, and she is also relatively positive that this is an app issue. If that is the case, she plans to open an issue at the app repository

[LeandraH]

Yes, I could fix the issue in the frontend in my local build. I rewrote the parsing of the recurrence rule a couple of weeks ago to fix a different bug and seem to have introduced this one, sorry! I'm currently adding more tests and will open a PR (and an issue) in the app repo later today.

[LeandraH]

Are we positive that the app only uses the endpoint with ?combine_recurring=True?

Yes, at least currently :)