Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent constraints for parent disciplines #310

Open
timobrembeck opened this issue Apr 5, 2022 · 0 comments
Open

Inconsistent constraints for parent disciplines #310

timobrembeck opened this issue Apr 5, 2022 · 0 comments
Labels
bug Something isn't working Prio:Medium

Comments

@timobrembeck
Copy link
Member

Describe the Bug

At the moment, in the discipline form only disciplines without training sets can be selected as parent disciplines.
However, this rule is not applied when the hierarchy is changed via drag & drop, which leads to inconsistencies.

Steps to Reproduce

  1. Go to disciplines
  2. Move a discipline to another discipline which has training sets

Expected Behavior

Show an error message that this is not possible

Actual Behavior

The discipline is moved without problems and the parent is set in the database.
Only when the form is opened, the parent "looks" empty (even though it's not) and when the form is saved, the parent is empty again.

Additional Information

I'm not sure what the intention is behind this constraint, but nonetheless - it should be enforced consistently in both the form and the drag & drop feature.

@timobrembeck timobrembeck added the bug Something isn't working label Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Prio:Medium
Projects
None yet
Development

No branches or pull requests

1 participant