Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bake: panic in progress printer #2598

Closed
crazy-max opened this issue Jul 15, 2024 · 1 comment · Fixed by #2603
Closed

bake: panic in progress printer #2598

crazy-max opened this issue Jul 15, 2024 · 1 comment · Fixed by #2603
Assignees
Labels
area/bake kind/bug Something isn't working
Milestone

Comments

@crazy-max
Copy link
Member

https://github.com/docker/buildx/actions/runs/9915811338/job/27397269631?pr=2595#step:6:259

  panic: runtime error: invalid memory address or nil pointer dereference
  [signal SIGSEGV: segmentation violation code=0x1 addr=0x40 pc=0x13d7ba7]
  
  goroutine 10 [running]:
  github.com/docker/buildx/util/progress.(*Printer).Warnings(...)
  	github.com/docker/buildx/util/progress/printer.go:65
  github.com/docker/buildx/commands.runBake.func2()
  	github.com/docker/buildx/commands/bake.go:149 +0x27
  github.com/docker/buildx/util/progress.NewPrinter.func1()
  	github.com/docker/buildx/util/progress/printer.go:129 +0x20a
  created by github.com/docker/buildx/util/progress.NewPrinter in goroutine 1
  	github.com/docker/buildx/util/progress/printer.go:112 +0x2b1

return dedupWarnings(p.warnings)

@crazy-max crazy-max added kind/bug Something isn't working area/bake labels Jul 15, 2024
@crazy-max crazy-max added this to the v0.16.1 milestone Jul 15, 2024
@tonistiigi
Copy link
Member

Looks like

printer = nil
runs before
printWarnings(os.Stderr, printer.Warnings(), progressMode)

Note that there is another similar section now in

printer = nil

This is a new code in v0.16.0 #2534 . Previously warnings were not printed for Bake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bake kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants