Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visitor's Country conditionlet throws errors when it cannot find a country for a request #30070

Open
swicken-dotcms opened this issue Sep 19, 2024 · 0 comments

Comments

@swicken-dotcms
Copy link
Contributor

Parent Issue

No response

Problem Statement

When a request IP cannot be resolved to a country by our Visitor's Country conditionlet in the Rules engine, it throws an error. This is not an error, and it's normal for certain requests to not be resolvable to a country, like health checks that come from local IP addresses.

Steps to Reproduce

I don't have reproduction steps, just change this logging from ERROR to DEBUG

[19/09/24 01:51:43:146 UTC] ERROR conditionlet.UsersCountryConditionlet: Could not look up country for request. Using 'unknown': https://192.168.190.15/api/v1/appconfiguration
[19/09/24 01:51:43:146 UTC] ERROR conditionlet.UsersCountryConditionlet: Could not look up country for request. Using 'unknown': https://192.168.190.15/api/v1/appconfiguration
[19/09/24 01:51:43:165 UTC] ERROR conditionlet.UsersCountryConditionlet: Could not look up country for request. Using 'unknown': https://192.168.190.15/api/v1/appconfiguration

Acceptance Criteria

No longer logging country resolution problems as an error

dotCMS Version

All versions

Proposed Objective

Technical User Experience

Proposed Priority

Priority 4 - Trivial

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: New
Development

No branches or pull requests

1 participant