Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Log Timestamp format/timezone configurable #115

Open
tlmii opened this issue Oct 7, 2023 · 7 comments
Open

Make Log Timestamp format/timezone configurable #115

tlmii opened this issue Oct 7, 2023 · 7 comments
Labels
area-dashboard enhancement An enhancement to an existing feature or capability.
Milestone

Comments

@tlmii
Copy link
Member

tlmii commented Oct 7, 2023

Currently the forced timestamps in the project logs are UTC time and of a format that roughly matches the one docker logs use. We should allow users to specify utc vs local and their own format.

@davidfowl
Copy link
Member

We should assume local and let you change to utc.

@dbreshears dbreshears added this to the some time after preview milestone Oct 10, 2023
@danmoseley danmoseley removed this from the needs milestone (for GA) milestone Nov 13, 2023
@kvenkatrajan
Copy link
Member

Would require settings storage design

@DamianEdwards
Copy link
Member

#303

Could we start with something simple like JSON serializing a settings object to a cookie?

@davidfowl
Copy link
Member

davidfowl commented Nov 21, 2023

We could punt this one for preview2

@tlmii
Copy link
Member Author

tlmii commented Nov 21, 2023

Could we start with something simple like JSON serializing a settings object to a cookie?

The code that configures it runs at startup of the Dashboard, not in the client. We used local storage in the client for other things (e.g. splitter bar size/position) but need something earlier for this. Unless we convert the format at runtime, I guess? But that seems like extra work for no reason. I guess it could go in AppHost's appsettings (and eventually the dashboard's wherever that lives), but if we want a UI for it we need something else I think?

@smitpatel
Copy link
Member

We should make it part of dashboard launch rather than setting on dashboard. If user want to change the format, restarting the dashboard is fine. We can make it configurable from code where we do AddAspireDashboard or similar in apphost.

@davidfowl davidfowl added this to the Backlog milestone Jan 27, 2024
@davidfowl
Copy link
Member

Putting this in the backlog

@davidfowl davidfowl added the enhancement An enhancement to an existing feature or capability. label Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-dashboard enhancement An enhancement to an existing feature or capability.
Projects
None yet
Development

No branches or pull requests

7 participants