Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the intention behind the 'percentage' on adjustments #458

Open
rszrama opened this issue Jul 23, 2021 · 1 comment
Open

Document the intention behind the 'percentage' on adjustments #458

rszrama opened this issue Jul 23, 2021 · 1 comment

Comments

@rszrama
Copy link
Collaborator

rszrama commented Jul 23, 2021

We document that adjustments have both an amount and a percentage, but we don't really discuss the relationship between those. Best I can tell, the percentage field is purely informational. I couldn't find anywhere in the code where it was actually used. If this is the case, we should make that clear so folks don't set the percentage and expect that to have some sort of recalculation impact on the amount.

@lisastreeter
Copy link
Collaborator

Good idea. Pull request has been created to update the Adjustments documentation page: #474

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants