Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Broker datapoints interface to retrieve metadata should include data type unit #102

Closed
mikehaller opened this issue Oct 30, 2023 · 4 comments

Comments

@mikehaller
Copy link

The data unit types of VSS should be exposed via GetMetadata as well.

Eg when subscribing to "Vehicle.Speed", the value is in "km/h" as specified. Since the spec can be overriden, it's hard for generic tools ("VSS Browser") to know the specific data type unit, unless it is exposed via the metadata interface.

@erikbosch
Copy link
Contributor

As this seems to concern databroker it should possibly be filed at https://github.com/eclipse/kuksa.val/issues instead.

@argerus - could you possibly give quick feedback. Is it Databroker that does not send unit to clients, or is clients that does not show it. No change in proto required I assume?

Test Client> getMetaData Vehicle.Speed
{
    "path": "Vehicle.Speed",
    "metadata": {
        "data_type": "FLOAT",
        "entry_type": "SENSOR",
        "description": "Vehicle speed."
    }
}

sdv.databroker.v1 > metadata Vehicle.Speed
[metadata]  OK  
Path          Entry type Data type
Vehicle.Speed Sensor     Float    

@erikbosch
Copy link
Contributor

@mikehaller @argerus - do we consider this one still relevant? If so I could "migrate" it to kuksa.val, or the new kuksa-databroker repo when migration is finished.

@mikehaller
Copy link
Author

Still relevant imo.

@erikbosch
Copy link
Contributor

Replaced by eclipse/kuksa.val#755

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants