Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element shows "Decryption key withheld" when it wasn't #23803

Closed
richvdh opened this issue Nov 20, 2022 · 2 comments · Fixed by matrix-org/matrix-js-sdk#3061
Closed

Element shows "Decryption key withheld" when it wasn't #23803

richvdh opened this issue Nov 20, 2022 · 2 comments · Fixed by matrix-org/matrix-js-sdk#3061
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@richvdh
Copy link
Member

richvdh commented Nov 20, 2022

When Element Android (and other clients based on matrix-android-sdk2) gets an m.room_key_request for a key that it doesn't have, it sends an m.room_key.withheld message with a code of m.unavailable (see implementation).

Having received the m.unavailable response, Element-web shows "Decryption key withheld", which is misleading at best.

@andybalaam andybalaam added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Nov 21, 2022
@robertmx
Copy link

Well #23745 was S-Major, as were some of the related bug reports. If the the chat suddenly stops working completely it probably should not be considered a minor inconvenience. I mean the core functionality breaks irrevocably without user interaction and does not recover without "expert" technical assistance.

Therefore I think it is appropriate to upgrade to S-major.

@richvdh
Copy link
Member Author

richvdh commented Jan 12, 2023

Therefore I think it is appropriate to upgrade to S-major.

It's just a misleading error message; this issue does not cause "the chat suddenly stops working completely". You may be thinking of some of the other crypto bugs, tracked at element-hq/element-meta#245.

su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Feb 1, 2023
* Implement decryption via the rust sdk ([\matrix-org#3074](matrix-org#3074)).
* Handle edits which are bundled with an event, per MSC3925 ([\matrix-org#3045](matrix-org#3045)).
* Add null check for our own member event ([\matrix-org#3082](matrix-org#3082)).
* Handle group call getting initialised twice in quick succession ([\matrix-org#3078](matrix-org#3078)). Fixes element-hq/element-call#847.
* Correctly handle limited sync responses by resetting the thread timeline ([\matrix-org#3056](matrix-org#3056)). Fixes element-hq/element-web#23952. Contributed by @justjanne.
* Fix failure to start in firefox private browser ([\matrix-org#3058](matrix-org#3058)). Fixes element-hq/element-web#24216.
* Fix spurious "Decryption key withheld" messages ([\matrix-org#3061](matrix-org#3061)). Fixes element-hq/element-web#23803.
* Fix browser entrypoint ([\matrix-org#3051](matrix-org#3051)). Fixes matrix-org#3013.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants