Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update prints to use a consistent format: #1046

Open
KennethEnevoldsen opened this issue Jul 5, 2024 · 2 comments
Open

Update prints to use a consistent format: #1046

KennethEnevoldsen opened this issue Jul 5, 2024 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@KennethEnevoldsen
Copy link
Contributor

We seem to use different methods for print throughout the code base, e.g.:

----------Using 8 data-parallel GPUs----------
─────────────────────────────── Selected tasks  ────────────────────────────────

We should probably be consistent in these
@KennethEnevoldsen KennethEnevoldsen added good first issue Good for newcomers help wanted Extra attention is needed labels Jul 5, 2024
@isaac-chung
Copy link
Collaborator

Might want to standardize logging as well - could be a separate issue.

@KennethEnevoldsen
Copy link
Contributor Author

KennethEnevoldsen commented Jul 7, 2024 •
edited
Loading

So whether we using the logging module, console.print (rich)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KennethEnevoldsen @isaac-chung