Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Add dependency change only mode #191

Open
pzuraq opened this issue May 9, 2018 · 2 comments
Open

[feature request] Add dependency change only mode #191

pzuraq opened this issue May 9, 2018 · 2 comments

Comments

@pzuraq
Copy link
Contributor

pzuraq commented May 9, 2018

Running into this with the ember-decorators library. Currently, the library is set up as a monorepo that consists of many addon packages, managed by lerna. This setup works well, but is very slow for testing. Even after consolidating all of the tests into the "main" ember-decorators package, it still takes twice as long as it would for a standard addon.

This is due to a double install occuring - first, lerna runs its install on every package via lerna bootstrap, and then links them up. Second, we run ember try:one in the main addon, which installs everything again.

I think ideally we would add a mode where you could only apply the diff to package.json in a given addon. Then, in our case, we would run the diff command first, then run lerna bootstrap, and have everything be installed and linked correctly in one go.

I'd be willing to open a PR for adding this if it seems like an acceptable feature.

@kategengler
Copy link
Member

We discussed this in chat, but since it was in Discord 👏 I was able to find it in history to summarize here:

  • There will still be a double install because ember-try needs to be installed to run
  • Short term, could make a lerna dependency adapter
  • Would also like to provide the ability to override install steps (cc @rwjblue)
  • Long term, an ember-try standalone cli would allow it to be installed globally and avoid a double install

@pzuraq
Copy link
Contributor Author

pzuraq commented Sep 1, 2018

❤️ discord, thanks for getting this down @kategengler!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants