You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 7, 2021. It is now read-only.
The current filters are not extensible, meaning that if a consumer wants to extend them, they have to replace them. Instead, allow consumers to specify additional filter configs, perhaps via a callback.
@pmuir Are you speaking about the filter component in ngx-widgets or the runtime console in general?
The filter component allows the user to make a simple selection from a list of options. For this, the component only needs a display value and an ID (optional). When the user selects an option, an event is generated with the filter config provided. However, the filter doesn't need additional config properties to do this. How the app implements the filter selection is up to you.
Are you looking to stuff more data in the filter config for convenience (e.g., a property of type any)? Is a callback what you're looking for?
@dlabrecq The filter component in ngx-widgets is great, and I like the model.
I'm actually talking about the way filters are going to work in this console (which aren't based on ngx-widgets at all).
But to make this a bit more abstract - basically if a Angular component A includes a filter in it, and then A itself is included in component B, how can B adjust the filter?
Actually, I think @ViewChild will do what I'm thinking about, so I suspect it's just a case of always making the filter config available on the same variable - i.e. a standard impl pattern. In that case doing #153 may be enough.
The current filters are not extensible, meaning that if a consumer wants to extend them, they have to replace them. Instead, allow consumers to specify additional filter configs, perhaps via a callback.
Depends on #153
The text was updated successfully, but these errors were encountered: