{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":4524181,"defaultBranch":"main","name":"folly","ownerLogin":"facebook","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2012-06-01T20:49:04.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/69631?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1726499068.0","currentOid":""},"activityList":{"items":[{"before":"534512c833329aca48c1a7b7504678e325bf4d1c","after":"56687951160736f9d6d80c48a155aa98b34d8564","ref":"refs/heads/main","pushedAt":"2024-09-19T18:16:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Rm experimental/JSONSchema.h\n\nSummary: tsia\n\nReviewed By: cgraf78\n\nDifferential Revision: D62757007\n\nfbshipit-source-id: 98740068a139851f47557bf7355e7e4a684b6789","shortMessageHtmlLink":"Rm experimental/JSONSchema.h"}},{"before":"7f69f881f693217889e5765fc07cbcebe8f8918a","after":"534512c833329aca48c1a7b7504678e325bf4d1c","ref":"refs/heads/main","pushedAt":"2024-09-19T17:00:53.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"chore: Set permissions for GitHub actions\n\nSummary:\nRestrict the GitHub token permissions only to the required ones; this way, even if the attackers will succeed in compromising your workflow, they won’t be able to do much.\n\n- Included permissions for the action. https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions\n\nhttps://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions\n\nhttps://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs\n\n[Keeping your GitHub Actions and workflows secure Part 1: Preventing pwn requests](https://securitylab.github.com/research/github-actions-preventing-pwn-requests/)\n\nSigned-off-by: neilnaveen <42328488+neilnaveen@users.noreply.github.com>\n\nX-link: https://github.com/facebook/proxygen/pull/413\n\nReviewed By: hanidamlaj\n\nDifferential Revision: D62986647\n\nPulled By: afrind\n\nfbshipit-source-id: 4c44009112169d50e735407caeb29be2e28a832a","shortMessageHtmlLink":"chore: Set permissions for GitHub actions"}},{"before":"ccf87eb78c1a2f6f1a67c47e035909f19e97b836","after":"7f69f881f693217889e5765fc07cbcebe8f8918a","ref":"refs/heads/main","pushedAt":"2024-09-18T21:54:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"adding test for modifying env within post-fork callback\n\nSummary:\nWill use this technique in the next diff in order to create a subprocess that contains an environment variable whose value is that subprocess's own pid.\n\nIt relies crucially on the environment strings remaining where they were when they were passed into the Subprocess c'tor (and not being moved or copied), so this test makes sure that that won't change on us.\n\nReviewed By: dmpolukhin\n\nDifferential Revision: D62691897\n\nfbshipit-source-id: ced30dfb2daa30067958a7feea819d8e49b35d4b","shortMessageHtmlLink":"adding test for modifying env within post-fork callback"}},{"before":"02ebbf5991e18c57f633405c4b364c7b8db25503","after":"ccf87eb78c1a2f6f1a67c47e035909f19e97b836","ref":"refs/heads/main","pushedAt":"2024-09-18T06:10:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"gh shims: Set up shim for `rust_linkable_symbol`\n\nSummary: So that we can use it in first party OSS projects\n\nReviewed By: dtolnay\n\nDifferential Revision:\nD62731699\n\nPrivacy Context Container: L1123788\n\nfbshipit-source-id: 892c43d69a34dd02cf2295ef665b41e45846982b","shortMessageHtmlLink":"gh shims: Set up shim for <code>rust_linkable_symbol</code>"}},{"before":"be81e0c0fda642fcc07a73b97ae14663352b479a","after":"02ebbf5991e18c57f633405c4b364c7b8db25503","ref":"refs/heads/main","pushedAt":"2024-09-18T02:10:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"fix new/delete in sanitize-address test\n\nSummary:\nThe use of `operator new` with sized `operator delete` in `folly/memory/test/SanitizeAddressTest.cpp` requires sized `operator delete`, which is not always available.\n\nDelegation to the correct `operator delete` is wrapped in `folly::operator_new` and `folly::operator_delete`, so switch to these.\n\nReviewed By: ckwalsh\n\nDifferential Revision: D62909014\n\nfbshipit-source-id: ce223473cdfe61ccfa50ba85e15a569aa9b245ea","shortMessageHtmlLink":"fix new/delete in sanitize-address test"}},{"before":"f67b93c9ff5f2b97d11ff384d2cef702c723cb5d","after":"be81e0c0fda642fcc07a73b97ae14663352b479a","ref":"refs/heads/main","pushedAt":"2024-09-18T01:31:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"fix packing example in PackedSyncPtrTest\n\nSummary: Latest compilers may require packing both the containing `struct` and the individual field of packable type in the `struct`.\n\nReviewed By: ckwalsh\n\nDifferential Revision: D62906425\n\nfbshipit-source-id: c49d8c4727f9c9aadf96cce64d392abac6f201da","shortMessageHtmlLink":"fix packing example in PackedSyncPtrTest"}},{"before":"74edd3bd4efe05c464ac71d7ccde52e3220869cf","after":"f67b93c9ff5f2b97d11ff384d2cef702c723cb5d","ref":"refs/heads/main","pushedAt":"2024-09-17T20:48:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Use sysfs if parsing /proc/cpuinfo doesn't work (#2291)\n\nSummary:\nOn Arm CPUs, such as NVIDIA Grace, /proc/cpuinfo may not contain the physical or core id, which is used to approximate the cache hierarchy. This PR implements a simple work-around: If parsing /proc/cpuinfo does not work, parse /sys/devices instead.\n\nPull Request resolved: https://github.com/facebook/folly/pull/2291\n\nTest Plan:\nImported from GitHub, without a `Test Plan:` line.\n\nSee D62316680 for context.\n\nConfirmed that this addresses the DigestBuilder issue on Grace ARM.\n\n```\nbuck2 run mode/opt //folly/stats/test:digest_builder_benchmark\n============================================================================\n[...]stats/test/DigestBuilderBenchmark.cpp     relative  time/iter   iters/s\n============================================================================\nappend(1000x1)                                             18.21ns    54.91M\nappend(1000x2)                                  99.622%    18.28ns    54.71M\nappend(1000x4)                                  98.997%    18.39ns    54.36M\nappend(1000x8)                                  98.705%    18.45ns    54.20M\nappend(1000x16)                                 98.598%    18.47ns    54.14M\nappend(1000x32)                                 97.641%    18.65ns    53.62M\n----------------------------------------------------------------------------\nappend(10000x1)                                            13.28ns    75.28M\nappend(10000x2)                                 99.304%    13.38ns    74.76M\nappend(10000x4)                                 98.784%    13.45ns    74.36M\nappend(10000x8)                                 98.265%    13.52ns    73.97M\nappend(10000x16)                                97.923%    13.57ns    73.72M\nappend(10000x32)                                96.585%    13.75ns    72.71M\n```\n\nCacheLocality.LinuxActual on Grace ARM\n**Before** (cpuinfo != sysfs, sysfs is correct)\n```\nI0911 13:03:23.131605 2626901 CacheLocalityTest.cpp:995] [cpuinfo] numCachesByLevel=[1, 1, 1]\nI0911 13:03:23.131691 2626901 CacheLocalityTest.cpp:997] [sysfs] numCachesByLevel=[72, 72, 1]\nI0911 13:03:23.131706 2626901 CacheLocalityTest.cpp:1000] [cpuinfo] equivClassesByCpu=[[0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0], [0, 0, 0]]\nI0911 13:03:23.132083 2626901 CacheLocalityTest.cpp:1002] [sysfs] equivClassesByCpu=[[0, 0, 0], [1, 1, 0], [2, 2, 0], [3, 3, 0], [4, 4, 0], [5, 5, 0], [6, 6, 0], [7, 7, 0], [8, 8, 0], [9, 9, 0], [10, 10, 0], [11, 11, 0], [12, 12, 0], [13, 13, 0], [14, 14, 0], [15, 15, 0], [16, 16, 0], [17, 17, 0], [18, 18, 0], [19, 19, 0], [20, 20, 0], [21, 21, 0], [22, 22, 0], [23, 23, 0], [24, 24, 0], [25, 25, 0], [26, 26, 0], [27, 27, 0], [28, 28, 0], [29, 29, 0], [30, 30, 0], [31, 31, 0], [32, 32, 0], [33, 33, 0], [34, 34, 0], [35, 35, 0], [36, 36, 0], [37, 37, 0], [38, 38, 0], [39, 39, 0], [40, 40, 0], [41, 41, 0], [42, 42, 0], [43, 43, 0], [44, 44, 0], [45, 45, 0], [46, 46, 0], [47, 47, 0], [48, 48, 0], [49, 49, 0], [50, 50, 0], [51, 51, 0], [52, 52, 0], [53, 53, 0], [54, 54, 0], [55, 55, 0], [56, 56, 0], [57, 57, 0], [58, 58, 0], [59, 59, 0], [60, 60, 0], [61, 61, 0], [62, 62, 0], [63, 63, 0], [64, 64, 0], [65, 65, 0], [66, 66, 0], [67, 67, 0], [68, 68, 0], [69, 69, 0], [70, 70, 0], [71, 71, 0]]\n```\n\nhttps://www.internalfb.com/intern/testinfra/testrun/1688850109822279\n\nReviewed By: yfeldblum, ot\n\nDifferential Revision: D62517069\n\nPulled By: meteorfox\n\nfbshipit-source-id: eced05417e0dd90357c575935a8f50bb2e27d122","shortMessageHtmlLink":"Use sysfs if parsing /proc/cpuinfo doesn't work (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2520087256\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/folly/issues/2291\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/folly/pull/2291/hovercard\" href=\"https://github.com/facebook/folly/pull/2291\">#2291</a>)"}},{"before":"641f0fbfed539eb5f87a74ed8de39596959daa61","after":"74edd3bd4efe05c464ac71d7ccde52e3220869cf","ref":"refs/heads/main","pushedAt":"2024-09-17T16:53:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Support fallback config when .pc file isn't available\n\nSummary:\nNot all distros (namely ubuntu) publish .pc files for their header packages.\nThis means that `pkg-config --libs <name>` fails, even though the headers are\navilable.\n\nWith this change, if `pkg-config` doesn't recognize the name, it can\npotentially fallback to a hardcoded value. It isn't perfect, but gets ubuntu\nbuilds to parity with fedora.\n\nReviewed By: bigfootjon\n\nDifferential Revision: D62789099\n\nfbshipit-source-id: 815ef0f978516c1b5079cf75fad71fdf03f34de2","shortMessageHtmlLink":"Support fallback config when .pc file isn't available"}},{"before":"5bf165e94f530215b27b87a755dc4d27e5e2ce12","after":"641f0fbfed539eb5f87a74ed8de39596959daa61","ref":"refs/heads/main","pushedAt":"2024-09-17T16:32:57.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"remove use of std::rand in FollyTest\n\nSummary: Fix linter complaint and make deterministic.\n\nReviewed By: yfeldblum\n\nDifferential Revision: D62766613\n\nfbshipit-source-id: a1b66a7ee43dfd31dde42ba0a3374b8a7d70a84a","shortMessageHtmlLink":"remove use of std::rand in FollyTest"}},{"before":"366de7f08c5280a69c90a9d6bc2c77f3f71463a8","after":"5bf165e94f530215b27b87a755dc4d27e5e2ce12","ref":"refs/heads/main","pushedAt":"2024-09-17T12:08:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"folly/coro/Coroutine.h: avoid a -Wdeprecated-this-capture warning\n\nSummary:\nAvoid build failure with xcode 15.4.\nWhile -Wdeprecated-experimental-coroutine was deleted in upstream llvm17,\n`__APPLE__` llvm reflects that deletion in their version llvm16.\nUpdating to xcode 16.0.0 RC1 makes this change unnecessary.\n\nReviewed By: Orvid\n\nDifferential Revision: D62769728\n\nfbshipit-source-id: 584ca8b09a3bce54fb5efa2365a9f447029db020","shortMessageHtmlLink":"folly/coro/Coroutine.h: avoid a -Wdeprecated-this-capture warning"}},{"before":"46366b4dae762d255e97b50fc2cd7ce75c2d44a1","after":"366de7f08c5280a69c90a9d6bc2c77f3f71463a8","ref":"refs/heads/main","pushedAt":"2024-09-17T02:22:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"no unique F14Chunk empty-tag-vector instance\n\nSummary:\nWith `F14Table`-based containers like `F14FastMap`, we have observed the impossibility of guaranteeing a single, process-wide, globally-unique instance of the chunk empty-tag-vector.\n\nInstead, we pick a unique invalid representation of the first pointer-sized word of the chunk and compare against it. This comes to a single extra indirection, plus the instructions for comparing against a constant which were already present anyway.\n\nReviewed By: akrieger\n\nDifferential Revision: D62062572\n\nfbshipit-source-id: 8f84f85276f1abcf2fdf70385e578e6b9f3895af","shortMessageHtmlLink":"no unique F14Chunk empty-tag-vector instance"}},{"before":"ccba90c06e65f9ff1ba5ec7a5a671a5244a5f6bc","after":"46366b4dae762d255e97b50fc2cd7ce75c2d44a1","ref":"refs/heads/main","pushedAt":"2024-09-16T21:15:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add __copy__ and __deepcopy__ to IOBuf and WritableIOBuf\n\nSummary: Add special methods `__copy__()` and `__deepcopy__()`\n\nReviewed By: fried\n\nDifferential Revision: D62497641\n\nfbshipit-source-id: 05a98f9d43a2d07461e9fbdeae40c1ec8470d6db","shortMessageHtmlLink":"Add __copy__ and __deepcopy__ to IOBuf and WritableIOBuf"}},{"before":"450183be456d1b3cad414e23a4b342878640729a","after":"ccba90c06e65f9ff1ba5ec7a5a671a5244a5f6bc","ref":"refs/heads/main","pushedAt":"2024-09-16T21:11:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"minor tweaks to align_floor, align_ceil\n\nReviewed By: DenisYaroshevskiy\n\nDifferential Revision: D62754195\n\nfbshipit-source-id: 141ef93237027d0f3a554ef142190a3ebbf74714","shortMessageHtmlLink":"minor tweaks to align_floor, align_ceil"}},{"before":"921d07017b4e1ad6e5427ed1f739babafa21b777","after":"450183be456d1b3cad414e23a4b342878640729a","ref":"refs/heads/main","pushedAt":"2024-09-16T19:19:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Move to use libcurl-minimal\n\nSummary:\nX-link: https://github.com/facebookincubator/zstrong/pull/992\n\nOSS Builds currently fail due to libcurl conflicting with libcurl-minimal. As far as I can tell, there are no blockers for moving FBOSS to use libcurl-minimal instead of libcurl.\n\nReviewed By: srikrishnagopu\n\nDifferential Revision:\nD62759136\n\nPrivacy Context Container: L1125642\n\nfbshipit-source-id: 79aa7fcc6f651cc074198f94e688b34b629a997f","shortMessageHtmlLink":"Move to use libcurl-minimal"}},{"before":"03be1748dae3d123778a8f5569f157cd9f576317","after":"921d07017b4e1ad6e5427ed1f739babafa21b777","ref":"refs/heads/main","pushedAt":"2024-09-16T18:34:33.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add liburing to third-party shims\n\nSummary: Used by OSS folly\n\nReviewed By: bigfootjon\n\nDifferential Revision: D62681698\n\nfbshipit-source-id: a679cb024ad12380a48e045d328440e1e0765d43","shortMessageHtmlLink":"Add liburing to third-party shims"}},{"before":"e4f90514d6c4e2b3dddb0b35d936345118d36401","after":"03be1748dae3d123778a8f5569f157cd9f576317","ref":"refs/heads/main","pushedAt":"2024-09-16T17:37:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Deshim coro in fbcode/folly\n\nSummary:\nThe following rules were deshimmed:\n```\n//folly/experimental/coro:accumulate -> //folly/coro:accumulate\n//folly/experimental/coro:async_generator -> //folly/coro:async_generator\n//folly/experimental/coro:async_pipe -> //folly/coro:async_pipe\n//folly/experimental/coro:async_scope -> //folly/coro:async_scope\n//folly/experimental/coro:async_stack -> //folly/coro:async_stack\n//folly/experimental/coro:baton -> //folly/coro:baton\n//folly/experimental/coro:blocking_wait -> //folly/coro:blocking_wait\n//folly/experimental/coro:collect -> //folly/coro:collect\n//folly/experimental/coro:concat -> //folly/coro:concat\n//folly/experimental/coro:coroutine -> //folly/coro:coroutine\n//folly/experimental/coro:current_executor -> //folly/coro:current_executor\n//folly/experimental/coro:detach_on_cancel -> //folly/coro:detach_on_cancel\n//folly/experimental/coro:detail_barrier -> //folly/coro:detail_barrier\n//folly/experimental/coro:detail_barrier_task -> //folly/coro:detail_barrier_task\n//folly/experimental/coro:detail_current_async_frame -> //folly/coro:detail_current_async_frame\n//folly/experimental/coro:detail_helpers -> //folly/coro:detail_helpers\n//folly/experimental/coro:detail_malloc -> //folly/coro:detail_malloc\n//folly/experimental/coro:detail_manual_lifetime -> //folly/coro:detail_manual_lifetime\n//folly/experimental/coro:detail_traits -> //folly/coro:detail_traits\n//folly/experimental/coro:filter -> //folly/coro:filter\n//folly/experimental/coro:future_util -> //folly/coro:future_util\n//folly/experimental/coro:generator -> //folly/coro:generator\n//folly/experimental/coro:gmock_helpers -> //folly/coro:gmock_helpers\n//folly/experimental/coro:gtest_helpers -> //folly/coro:gtest_helpers\n//folly/experimental/coro:inline_task -> //folly/coro:inline_task\n//folly/experimental/coro:invoke -> //folly/coro:invoke\n//folly/experimental/coro:merge -> //folly/coro:merge\n//folly/experimental/coro:mutex -> //folly/coro:mutex\n//folly/experimental/coro:promise -> //folly/coro:promise\n//folly/experimental/coro:result -> //folly/coro:result\n//folly/experimental/coro:retry -> //folly/coro:retry\n//folly/experimental/coro:rust_adaptors -> //folly/coro:rust_adaptors\n//folly/experimental/coro:scope_exit -> //folly/coro:scope_exit\n//folly/experimental/coro:shared_lock -> //folly/coro:shared_lock\n//folly/experimental/coro:shared_mutex -> //folly/coro:shared_mutex\n//folly/experimental/coro:sleep -> //folly/coro:sleep\n//folly/experimental/coro:small_unbounded_queue -> //folly/coro:small_unbounded_queue\n//folly/experimental/coro:task -> //folly/coro:task\n//folly/experimental/coro:timed_wait -> //folly/coro:timed_wait\n//folly/experimental/coro:timeout -> //folly/coro:timeout\n//folly/experimental/coro:traits -> //folly/coro:traits\n//folly/experimental/coro:transform -> //folly/coro:transform\n//folly/experimental/coro:unbounded_queue -> //folly/coro:unbounded_queue\n//folly/experimental/coro:via_if_async -> //folly/coro:via_if_async\n//folly/experimental/coro:with_async_stack -> //folly/coro:with_async_stack\n//folly/experimental/coro:with_cancellation -> //folly/coro:with_cancellation\n//folly/experimental/coro:bounded_queue -> //folly/coro:bounded_queue\n//folly/experimental/coro:shared_promise -> //folly/coro:shared_promise\n//folly/experimental/coro:cleanup -> //folly/coro:cleanup\n//folly/experimental/coro:auto_cleanup_fwd -> //folly/coro:auto_cleanup_fwd\n//folly/experimental/coro:auto_cleanup -> //folly/coro:auto_cleanup\n```\n\nThe following headers were deshimmed:\n```\nfolly/experimental/coro/Accumulate.h -> folly/coro/Accumulate.h\nfolly/experimental/coro/Accumulate-inl.h -> folly/coro/Accumulate-inl.h\nfolly/experimental/coro/AsyncGenerator.h -> folly/coro/AsyncGenerator.h\nfolly/experimental/coro/AsyncPipe.h -> folly/coro/AsyncPipe.h\nfolly/experimental/coro/AsyncScope.h -> folly/coro/AsyncScope.h\nfolly/experimental/coro/AsyncStack.h -> folly/coro/AsyncStack.h\nfolly/experimental/coro/Baton.h -> folly/coro/Baton.h\nfolly/experimental/coro/BlockingWait.h -> folly/coro/BlockingWait.h\nfolly/experimental/coro/Collect.h -> folly/coro/Collect.h\nfolly/experimental/coro/Collect-inl.h -> folly/coro/Collect-inl.h\nfolly/experimental/coro/Concat.h -> folly/coro/Concat.h\nfolly/experimental/coro/Concat-inl.h -> folly/coro/Concat-inl.h\nfolly/experimental/coro/Coroutine.h -> folly/coro/Coroutine.h\nfolly/experimental/coro/CurrentExecutor.h -> folly/coro/CurrentExecutor.h\nfolly/experimental/coro/DetachOnCancel.h -> folly/coro/DetachOnCancel.h\nfolly/experimental/coro/detail/Barrier.h -> folly/coro/detail/Barrier.h\nfolly/experimental/coro/detail/BarrierTask.h -> folly/coro/detail/BarrierTask.h\nfolly/experimental/coro/detail/CurrentAsyncFrame.h -> folly/coro/detail/CurrentAsyncFrame.h\nfolly/experimental/coro/detail/Helpers.h -> folly/coro/detail/Helpers.h\nfolly/experimental/coro/detail/Malloc.h -> folly/coro/detail/Malloc.h\nfolly/experimental/coro/detail/ManualLifetime.h -> folly/coro/detail/ManualLifetime.h\nfolly/experimental/coro/detail/Traits.h -> folly/coro/detail/Traits.h\nfolly/experimental/coro/Filter.h -> folly/coro/Filter.h\nfolly/experimental/coro/Filter-inl.h -> folly/coro/Filter-inl.h\nfolly/experimental/coro/FutureUtil.h -> folly/coro/FutureUtil.h\nfolly/experimental/coro/Generator.h -> folly/coro/Generator.h\nfolly/experimental/coro/GmockHelpers.h -> folly/coro/GmockHelpers.h\nfolly/experimental/coro/GtestHelpers.h -> folly/coro/GtestHelpers.h\nfolly/experimental/coro/detail/InlineTask.h -> folly/coro/detail/InlineTask.h\nfolly/experimental/coro/Invoke.h -> folly/coro/Invoke.h\nfolly/experimental/coro/Merge.h -> folly/coro/Merge.h\nfolly/experimental/coro/Merge-inl.h -> folly/coro/Merge-inl.h\nfolly/experimental/coro/Mutex.h -> folly/coro/Mutex.h\nfolly/experimental/coro/Promise.h -> folly/coro/Promise.h\nfolly/experimental/coro/Result.h -> folly/coro/Result.h\nfolly/experimental/coro/Retry.h -> folly/coro/Retry.h\nfolly/experimental/coro/RustAdaptors.h -> folly/coro/RustAdaptors.h\nfolly/experimental/coro/ScopeExit.h -> folly/coro/ScopeExit.h\nfolly/experimental/coro/SharedLock.h -> folly/coro/SharedLock.h\nfolly/experimental/coro/SharedMutex.h -> folly/coro/SharedMutex.h\nfolly/experimental/coro/Sleep.h -> folly/coro/Sleep.h\nfolly/experimental/coro/Sleep-inl.h -> folly/coro/Sleep-inl.h\nfolly/experimental/coro/SmallUnboundedQueue.h -> folly/coro/SmallUnboundedQueue.h\nfolly/experimental/coro/Task.h -> folly/coro/Task.h\nfolly/experimental/coro/TimedWait.h -> folly/coro/TimedWait.h\nfolly/experimental/coro/Timeout.h -> folly/coro/Timeout.h\nfolly/experimental/coro/Timeout-inl.h -> folly/coro/Timeout-inl.h\nfolly/experimental/coro/Traits.h -> folly/coro/Traits.h\nfolly/experimental/coro/Transform.h -> folly/coro/Transform.h\nfolly/experimental/coro/Transform-inl.h -> folly/coro/Transform-inl.h\nfolly/experimental/coro/UnboundedQueue.h -> folly/coro/UnboundedQueue.h\nfolly/experimental/coro/ViaIfAsync.h -> folly/coro/ViaIfAsync.h\nfolly/experimental/coro/WithAsyncStack.h -> folly/coro/WithAsyncStack.h\nfolly/experimental/coro/WithCancellation.h -> folly/coro/WithCancellation.h\nfolly/experimental/coro/BoundedQueue.h -> folly/coro/BoundedQueue.h\nfolly/experimental/coro/SharedPromise.h -> folly/coro/SharedPromise.h\nfolly/experimental/coro/Cleanup.h -> folly/coro/Cleanup.h\nfolly/experimental/coro/AutoCleanup-fwd.h -> folly/coro/AutoCleanup-fwd.h\nfolly/experimental/coro/AutoCleanup.h -> folly/coro/AutoCleanup.h\n```\n\nThis is a codemod. It was automatically generated and will be landed once it is approved and tests are passing in sandcastle.\nYou have been added as a reviewer by Sentinel or Butterfly.\n\nAutodiff project: dcoro\nAutodiff partition: fbcode.folly\nAutodiff bookmark: ad.dcoro.fbcode.folly\n\nReviewed By: dtolnay\n\nDifferential Revision: D62684498\n\nfbshipit-source-id: aeef2c0dbfa87775ebd696635ea423aac3633e47","shortMessageHtmlLink":"Deshim coro in fbcode/folly"}},{"before":"4dcdd84770f69518fbff85e1b8ff08c319bdb48a","after":"e4f90514d6c4e2b3dddb0b35d936345118d36401","ref":"refs/heads/main","pushedAt":"2024-09-16T16:43:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add doc for folly/MapUtil\n\nSummary: Add documentation for folly/MapUtil.h. Documentation provides a section on the motivation of the utility as well as some examples (mostly pulled from the unit tests)\n\nReviewed By: Gownta\n\nDifferential Revision: D62447206\n\nfbshipit-source-id: fd869aa558ef38398248a15b7c196673d6cb9269","shortMessageHtmlLink":"Add doc for folly/MapUtil"}},{"before":"f7189afafc220bf1fea3aa118158cf0b7ad6b9ed","after":"4dcdd84770f69518fbff85e1b8ff08c319bdb48a","ref":"refs/heads/main","pushedAt":"2024-09-16T16:35:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/buck2-prelude/commit/17ab7afe7270b57ca9f810e896b7bbcfd700375f\nhttps://github.com/facebook/fb303/commit/dd6f8d09407455260cf0713db2e116cfa19acab4\nhttps://github.com/facebook/fbthrift/commit/e3d27fc1f7ddbfdd6fa9a9722b20fe75f53209bc\nhttps://github.com/facebook/folly/commit/f7189afafc220bf1fea3aa118158cf0b7ad6b9ed\nhttps://github.com/facebook/mvfst/commit/843c8bd50a11fd551ac973ca2ae84cb130ed2807\nhttps://github.com/facebook/proxygen/commit/376776a7a966552ce1849f4624ce40668932e263\nhttps://github.com/facebook/wangle/commit/3e96366fb9a4366b0b191718d9cc1af992442b72\nhttps://github.com/facebookexperimental/edencommon/commit/09f3e3543b29a35d2287f96aef641c2f2ea07d82\nhttps://github.com/facebookexperimental/rust-shed/commit/6c16de2e50f8f38a65e3dbc4ca41772471c0f803\nhttps://github.com/facebookincubator/fizz/commit/15356f47e089a115d859a000bd5f7c33581c6505\n\nReviewed By: bigfootjon\n\nfbshipit-source-id: b04cc4e1faf9a3b81bea41816036b3913117629b","shortMessageHtmlLink":"Updating submodules"}},{"before":"c6b96b2590b487c6a554e20d905bcd40ad303cc5","after":"f7189afafc220bf1fea3aa118158cf0b7ad6b9ed","ref":"refs/heads/main","pushedAt":"2024-09-16T10:41:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Don't disable folly tracepoints on Android\n\nSummary:\nFolly tracepoints were initially disabled on Android in D13293303 landed in 2018 when only x86 tracepoints were supported. D57171286 landed in May 2024 added support for aarch64 tracepoints, but remained disabled on Android by default.\n\nThis diff removes the no longer unnecessary flag and enables tracepoints by default.\n\nDifferential Revision: D62638793\n\nfbshipit-source-id: c3f89d19d911b748dcc26bebb56392666bee99f6","shortMessageHtmlLink":"Don't disable folly tracepoints on Android"}},{"before":"b6e67d78ea47e64d09cc762051bc071822c90dab","after":"c6b96b2590b487c6a554e20d905bcd40ad303cc5","ref":"refs/heads/main","pushedAt":"2024-09-16T04:50:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Mark some folly::Try functions are noexcept\n\nSummary:\nThese functions are intended not to throw and they do not throw, so lets mark them as non-throwing.\n\n`hasValue()` and `hasException()` are self-explanatory.\n\n`tryGetExceptionObject()` returns `nullptr` on failure, which is similarly self-explanatory.\n\n`makeTryWith(F&&)` is intended not to throw and never throws in practice. Caveat: this function never throws in practice as of C++17 and its syntactic copy-elision of returned temporaries, but may have thrown in practice before C++17 for `Try<T>` in cases where `T` is not noexcept-move-constructible.\n\nReviewed By: yfeldblum\n\nDifferential Revision: D62713625\n\nfbshipit-source-id: 9e91fee5b56da5c366dc6120ed5648afbae6e02c","shortMessageHtmlLink":"Mark some folly::Try functions are noexcept"}},{"before":"1ccbcb570c8b69ef0bab81a5511fcb7e43df7f4a","after":"b6e67d78ea47e64d09cc762051bc071822c90dab","ref":"refs/heads/main","pushedAt":"2024-09-15T20:05:18.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add missing #include<utility>\n\nSummary:\nThis file uses std::exchange(), defined in utility, but does not include it.\nThis caused a failure in OSS folly buck2 builds\n\nReviewed By: yfeldblum\n\nDifferential Revision: D62624810\n\nfbshipit-source-id: c2a3b889788a1e9426e65efd4bafd875bbb28632","shortMessageHtmlLink":"Add missing #include&lt;utility&gt;"}},{"before":"8a5e31a1ce42d05133b9b2951f2bb0345cea93cc","after":"1ccbcb570c8b69ef0bab81a5511fcb7e43df7f4a","ref":"refs/heads/main","pushedAt":"2024-09-15T18:14:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Mark liburing dependency skip as fb-only\n\nSummary:\n`ovr_config//os:linux-sgx` is a special target that matches a specific internal\ntoolchain, and is not relevant to OSS folly. By marking this as fb-only, OSS\nfolly properly links in liburing and buils for uring based targets start\nworking.\n\nReviewed By: yfeldblum\n\nDifferential Revision: D62681697\n\nfbshipit-source-id: b6ed3e31236a95c0c94929b4b4fd10ce886e6709","shortMessageHtmlLink":"Mark liburing dependency skip as fb-only"}},{"before":"a8d1cb2deac08d3a19182d24684fe23d37ba25d2","after":"8a5e31a1ce42d05133b9b2951f2bb0345cea93cc","ref":"refs/heads/main","pushedAt":"2024-09-14T19:07:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Deshim coro in fbcode/folly/channels\n\nSummary:\nThe following rules were deshimmed:\n```\n//folly/experimental/coro:accumulate -> //folly/coro:accumulate\n//folly/experimental/coro:async_generator -> //folly/coro:async_generator\n//folly/experimental/coro:async_pipe -> //folly/coro:async_pipe\n//folly/experimental/coro:async_scope -> //folly/coro:async_scope\n//folly/experimental/coro:async_stack -> //folly/coro:async_stack\n//folly/experimental/coro:baton -> //folly/coro:baton\n//folly/experimental/coro:blocking_wait -> //folly/coro:blocking_wait\n//folly/experimental/coro:collect -> //folly/coro:collect\n//folly/experimental/coro:concat -> //folly/coro:concat\n//folly/experimental/coro:coroutine -> //folly/coro:coroutine\n//folly/experimental/coro:current_executor -> //folly/coro:current_executor\n//folly/experimental/coro:detach_on_cancel -> //folly/coro:detach_on_cancel\n//folly/experimental/coro:detail_barrier -> //folly/coro:detail_barrier\n//folly/experimental/coro:detail_barrier_task -> //folly/coro:detail_barrier_task\n//folly/experimental/coro:detail_current_async_frame -> //folly/coro:detail_current_async_frame\n//folly/experimental/coro:detail_helpers -> //folly/coro:detail_helpers\n//folly/experimental/coro:detail_malloc -> //folly/coro:detail_malloc\n//folly/experimental/coro:detail_manual_lifetime -> //folly/coro:detail_manual_lifetime\n//folly/experimental/coro:detail_traits -> //folly/coro:detail_traits\n//folly/experimental/coro:filter -> //folly/coro:filter\n//folly/experimental/coro:future_util -> //folly/coro:future_util\n//folly/experimental/coro:generator -> //folly/coro:generator\n//folly/experimental/coro:gmock_helpers -> //folly/coro:gmock_helpers\n//folly/experimental/coro:gtest_helpers -> //folly/coro:gtest_helpers\n//folly/experimental/coro:inline_task -> //folly/coro:inline_task\n//folly/experimental/coro:invoke -> //folly/coro:invoke\n//folly/experimental/coro:merge -> //folly/coro:merge\n//folly/experimental/coro:mutex -> //folly/coro:mutex\n//folly/experimental/coro:promise -> //folly/coro:promise\n//folly/experimental/coro:result -> //folly/coro:result\n//folly/experimental/coro:retry -> //folly/coro:retry\n//folly/experimental/coro:rust_adaptors -> //folly/coro:rust_adaptors\n//folly/experimental/coro:scope_exit -> //folly/coro:scope_exit\n//folly/experimental/coro:shared_lock -> //folly/coro:shared_lock\n//folly/experimental/coro:shared_mutex -> //folly/coro:shared_mutex\n//folly/experimental/coro:sleep -> //folly/coro:sleep\n//folly/experimental/coro:small_unbounded_queue -> //folly/coro:small_unbounded_queue\n//folly/experimental/coro:task -> //folly/coro:task\n//folly/experimental/coro:timed_wait -> //folly/coro:timed_wait\n//folly/experimental/coro:timeout -> //folly/coro:timeout\n//folly/experimental/coro:traits -> //folly/coro:traits\n//folly/experimental/coro:transform -> //folly/coro:transform\n//folly/experimental/coro:unbounded_queue -> //folly/coro:unbounded_queue\n//folly/experimental/coro:via_if_async -> //folly/coro:via_if_async\n//folly/experimental/coro:with_async_stack -> //folly/coro:with_async_stack\n//folly/experimental/coro:with_cancellation -> //folly/coro:with_cancellation\n//folly/experimental/coro:bounded_queue -> //folly/coro:bounded_queue\n//folly/experimental/coro:shared_promise -> //folly/coro:shared_promise\n//folly/experimental/coro:cleanup -> //folly/coro:cleanup\n//folly/experimental/coro:auto_cleanup_fwd -> //folly/coro:auto_cleanup_fwd\n//folly/experimental/coro:auto_cleanup -> //folly/coro:auto_cleanup\n```\n\nThe following headers were deshimmed:\n```\nfolly/experimental/coro/Accumulate.h -> folly/coro/Accumulate.h\nfolly/experimental/coro/Accumulate-inl.h -> folly/coro/Accumulate-inl.h\nfolly/experimental/coro/AsyncGenerator.h -> folly/coro/AsyncGenerator.h\nfolly/experimental/coro/AsyncPipe.h -> folly/coro/AsyncPipe.h\nfolly/experimental/coro/AsyncScope.h -> folly/coro/AsyncScope.h\nfolly/experimental/coro/AsyncStack.h -> folly/coro/AsyncStack.h\nfolly/experimental/coro/Baton.h -> folly/coro/Baton.h\nfolly/experimental/coro/BlockingWait.h -> folly/coro/BlockingWait.h\nfolly/experimental/coro/Collect.h -> folly/coro/Collect.h\nfolly/experimental/coro/Collect-inl.h -> folly/coro/Collect-inl.h\nfolly/experimental/coro/Concat.h -> folly/coro/Concat.h\nfolly/experimental/coro/Concat-inl.h -> folly/coro/Concat-inl.h\nfolly/experimental/coro/Coroutine.h -> folly/coro/Coroutine.h\nfolly/experimental/coro/CurrentExecutor.h -> folly/coro/CurrentExecutor.h\nfolly/experimental/coro/DetachOnCancel.h -> folly/coro/DetachOnCancel.h\nfolly/experimental/coro/detail/Barrier.h -> folly/coro/detail/Barrier.h\nfolly/experimental/coro/detail/BarrierTask.h -> folly/coro/detail/BarrierTask.h\nfolly/experimental/coro/detail/CurrentAsyncFrame.h -> folly/coro/detail/CurrentAsyncFrame.h\nfolly/experimental/coro/detail/Helpers.h -> folly/coro/detail/Helpers.h\nfolly/experimental/coro/detail/Malloc.h -> folly/coro/detail/Malloc.h\nfolly/experimental/coro/detail/ManualLifetime.h -> folly/coro/detail/ManualLifetime.h\nfolly/experimental/coro/detail/Traits.h -> folly/coro/detail/Traits.h\nfolly/experimental/coro/Filter.h -> folly/coro/Filter.h\nfolly/experimental/coro/Filter-inl.h -> folly/coro/Filter-inl.h\nfolly/experimental/coro/FutureUtil.h -> folly/coro/FutureUtil.h\nfolly/experimental/coro/Generator.h -> folly/coro/Generator.h\nfolly/experimental/coro/GmockHelpers.h -> folly/coro/GmockHelpers.h\nfolly/experimental/coro/GtestHelpers.h -> folly/coro/GtestHelpers.h\nfolly/experimental/coro/detail/InlineTask.h -> folly/coro/detail/InlineTask.h\nfolly/experimental/coro/Invoke.h -> folly/coro/Invoke.h\nfolly/experimental/coro/Merge.h -> folly/coro/Merge.h\nfolly/experimental/coro/Merge-inl.h -> folly/coro/Merge-inl.h\nfolly/experimental/coro/Mutex.h -> folly/coro/Mutex.h\nfolly/experimental/coro/Promise.h -> folly/coro/Promise.h\nfolly/experimental/coro/Result.h -> folly/coro/Result.h\nfolly/experimental/coro/Retry.h -> folly/coro/Retry.h\nfolly/experimental/coro/RustAdaptors.h -> folly/coro/RustAdaptors.h\nfolly/experimental/coro/ScopeExit.h -> folly/coro/ScopeExit.h\nfolly/experimental/coro/SharedLock.h -> folly/coro/SharedLock.h\nfolly/experimental/coro/SharedMutex.h -> folly/coro/SharedMutex.h\nfolly/experimental/coro/Sleep.h -> folly/coro/Sleep.h\nfolly/experimental/coro/Sleep-inl.h -> folly/coro/Sleep-inl.h\nfolly/experimental/coro/SmallUnboundedQueue.h -> folly/coro/SmallUnboundedQueue.h\nfolly/experimental/coro/Task.h -> folly/coro/Task.h\nfolly/experimental/coro/TimedWait.h -> folly/coro/TimedWait.h\nfolly/experimental/coro/Timeout.h -> folly/coro/Timeout.h\nfolly/experimental/coro/Timeout-inl.h -> folly/coro/Timeout-inl.h\nfolly/experimental/coro/Traits.h -> folly/coro/Traits.h\nfolly/experimental/coro/Transform.h -> folly/coro/Transform.h\nfolly/experimental/coro/Transform-inl.h -> folly/coro/Transform-inl.h\nfolly/experimental/coro/UnboundedQueue.h -> folly/coro/UnboundedQueue.h\nfolly/experimental/coro/ViaIfAsync.h -> folly/coro/ViaIfAsync.h\nfolly/experimental/coro/WithAsyncStack.h -> folly/coro/WithAsyncStack.h\nfolly/experimental/coro/WithCancellation.h -> folly/coro/WithCancellation.h\nfolly/experimental/coro/BoundedQueue.h -> folly/coro/BoundedQueue.h\nfolly/experimental/coro/SharedPromise.h -> folly/coro/SharedPromise.h\nfolly/experimental/coro/Cleanup.h -> folly/coro/Cleanup.h\nfolly/experimental/coro/AutoCleanup-fwd.h -> folly/coro/AutoCleanup-fwd.h\nfolly/experimental/coro/AutoCleanup.h -> folly/coro/AutoCleanup.h\n```\n\nThis is a codemod. It was automatically generated and will be landed once it is approved and tests are passing in sandcastle.\nYou have been added as a reviewer by Sentinel or Butterfly.\n\nAutodiff project: dcoro\nAutodiff partition: fbcode.folly.channels\nAutodiff bookmark: ad.dcoro.fbcode.folly.channels\n\nReviewed By: yfeldblum, dtolnay\n\nDifferential Revision: D62684178\n\nfbshipit-source-id: ab91882fda294f48927b529ab57e4ecfb52a0e31","shortMessageHtmlLink":"Deshim coro in fbcode/folly/channels"}},{"before":"58f15742af8c4aa087f66d46e91ca4c3407de220","after":"a8d1cb2deac08d3a19182d24684fe23d37ba25d2","ref":"refs/heads/main","pushedAt":"2024-09-14T17:13:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Deshim coro in fbcode/folly/io\n\nSummary:\nThe following rules were deshimmed:\n```\n//folly/experimental/coro:accumulate -> //folly/coro:accumulate\n//folly/experimental/coro:async_generator -> //folly/coro:async_generator\n//folly/experimental/coro:async_pipe -> //folly/coro:async_pipe\n//folly/experimental/coro:async_scope -> //folly/coro:async_scope\n//folly/experimental/coro:async_stack -> //folly/coro:async_stack\n//folly/experimental/coro:baton -> //folly/coro:baton\n//folly/experimental/coro:blocking_wait -> //folly/coro:blocking_wait\n//folly/experimental/coro:collect -> //folly/coro:collect\n//folly/experimental/coro:concat -> //folly/coro:concat\n//folly/experimental/coro:coroutine -> //folly/coro:coroutine\n//folly/experimental/coro:current_executor -> //folly/coro:current_executor\n//folly/experimental/coro:detach_on_cancel -> //folly/coro:detach_on_cancel\n//folly/experimental/coro:detail_barrier -> //folly/coro:detail_barrier\n//folly/experimental/coro:detail_barrier_task -> //folly/coro:detail_barrier_task\n//folly/experimental/coro:detail_current_async_frame -> //folly/coro:detail_current_async_frame\n//folly/experimental/coro:detail_helpers -> //folly/coro:detail_helpers\n//folly/experimental/coro:detail_malloc -> //folly/coro:detail_malloc\n//folly/experimental/coro:detail_manual_lifetime -> //folly/coro:detail_manual_lifetime\n//folly/experimental/coro:detail_traits -> //folly/coro:detail_traits\n//folly/experimental/coro:filter -> //folly/coro:filter\n//folly/experimental/coro:future_util -> //folly/coro:future_util\n//folly/experimental/coro:generator -> //folly/coro:generator\n//folly/experimental/coro:gmock_helpers -> //folly/coro:gmock_helpers\n//folly/experimental/coro:gtest_helpers -> //folly/coro:gtest_helpers\n//folly/experimental/coro:inline_task -> //folly/coro:inline_task\n//folly/experimental/coro:invoke -> //folly/coro:invoke\n//folly/experimental/coro:merge -> //folly/coro:merge\n//folly/experimental/coro:mutex -> //folly/coro:mutex\n//folly/experimental/coro:promise -> //folly/coro:promise\n//folly/experimental/coro:result -> //folly/coro:result\n//folly/experimental/coro:retry -> //folly/coro:retry\n//folly/experimental/coro:rust_adaptors -> //folly/coro:rust_adaptors\n//folly/experimental/coro:scope_exit -> //folly/coro:scope_exit\n//folly/experimental/coro:shared_lock -> //folly/coro:shared_lock\n//folly/experimental/coro:shared_mutex -> //folly/coro:shared_mutex\n//folly/experimental/coro:sleep -> //folly/coro:sleep\n//folly/experimental/coro:small_unbounded_queue -> //folly/coro:small_unbounded_queue\n//folly/experimental/coro:task -> //folly/coro:task\n//folly/experimental/coro:timed_wait -> //folly/coro:timed_wait\n//folly/experimental/coro:timeout -> //folly/coro:timeout\n//folly/experimental/coro:traits -> //folly/coro:traits\n//folly/experimental/coro:transform -> //folly/coro:transform\n//folly/experimental/coro:unbounded_queue -> //folly/coro:unbounded_queue\n//folly/experimental/coro:via_if_async -> //folly/coro:via_if_async\n//folly/experimental/coro:with_async_stack -> //folly/coro:with_async_stack\n//folly/experimental/coro:with_cancellation -> //folly/coro:with_cancellation\n//folly/experimental/coro:bounded_queue -> //folly/coro:bounded_queue\n//folly/experimental/coro:shared_promise -> //folly/coro:shared_promise\n//folly/experimental/coro:cleanup -> //folly/coro:cleanup\n//folly/experimental/coro:auto_cleanup_fwd -> //folly/coro:auto_cleanup_fwd\n//folly/experimental/coro:auto_cleanup -> //folly/coro:auto_cleanup\n```\n\nThe following headers were deshimmed:\n```\nfolly/experimental/coro/Accumulate.h -> folly/coro/Accumulate.h\nfolly/experimental/coro/Accumulate-inl.h -> folly/coro/Accumulate-inl.h\nfolly/experimental/coro/AsyncGenerator.h -> folly/coro/AsyncGenerator.h\nfolly/experimental/coro/AsyncPipe.h -> folly/coro/AsyncPipe.h\nfolly/experimental/coro/AsyncScope.h -> folly/coro/AsyncScope.h\nfolly/experimental/coro/AsyncStack.h -> folly/coro/AsyncStack.h\nfolly/experimental/coro/Baton.h -> folly/coro/Baton.h\nfolly/experimental/coro/BlockingWait.h -> folly/coro/BlockingWait.h\nfolly/experimental/coro/Collect.h -> folly/coro/Collect.h\nfolly/experimental/coro/Collect-inl.h -> folly/coro/Collect-inl.h\nfolly/experimental/coro/Concat.h -> folly/coro/Concat.h\nfolly/experimental/coro/Concat-inl.h -> folly/coro/Concat-inl.h\nfolly/experimental/coro/Coroutine.h -> folly/coro/Coroutine.h\nfolly/experimental/coro/CurrentExecutor.h -> folly/coro/CurrentExecutor.h\nfolly/experimental/coro/DetachOnCancel.h -> folly/coro/DetachOnCancel.h\nfolly/experimental/coro/detail/Barrier.h -> folly/coro/detail/Barrier.h\nfolly/experimental/coro/detail/BarrierTask.h -> folly/coro/detail/BarrierTask.h\nfolly/experimental/coro/detail/CurrentAsyncFrame.h -> folly/coro/detail/CurrentAsyncFrame.h\nfolly/experimental/coro/detail/Helpers.h -> folly/coro/detail/Helpers.h\nfolly/experimental/coro/detail/Malloc.h -> folly/coro/detail/Malloc.h\nfolly/experimental/coro/detail/ManualLifetime.h -> folly/coro/detail/ManualLifetime.h\nfolly/experimental/coro/detail/Traits.h -> folly/coro/detail/Traits.h\nfolly/experimental/coro/Filter.h -> folly/coro/Filter.h\nfolly/experimental/coro/Filter-inl.h -> folly/coro/Filter-inl.h\nfolly/experimental/coro/FutureUtil.h -> folly/coro/FutureUtil.h\nfolly/experimental/coro/Generator.h -> folly/coro/Generator.h\nfolly/experimental/coro/GmockHelpers.h -> folly/coro/GmockHelpers.h\nfolly/experimental/coro/GtestHelpers.h -> folly/coro/GtestHelpers.h\nfolly/experimental/coro/detail/InlineTask.h -> folly/coro/detail/InlineTask.h\nfolly/experimental/coro/Invoke.h -> folly/coro/Invoke.h\nfolly/experimental/coro/Merge.h -> folly/coro/Merge.h\nfolly/experimental/coro/Merge-inl.h -> folly/coro/Merge-inl.h\nfolly/experimental/coro/Mutex.h -> folly/coro/Mutex.h\nfolly/experimental/coro/Promise.h -> folly/coro/Promise.h\nfolly/experimental/coro/Result.h -> folly/coro/Result.h\nfolly/experimental/coro/Retry.h -> folly/coro/Retry.h\nfolly/experimental/coro/RustAdaptors.h -> folly/coro/RustAdaptors.h\nfolly/experimental/coro/ScopeExit.h -> folly/coro/ScopeExit.h\nfolly/experimental/coro/SharedLock.h -> folly/coro/SharedLock.h\nfolly/experimental/coro/SharedMutex.h -> folly/coro/SharedMutex.h\nfolly/experimental/coro/Sleep.h -> folly/coro/Sleep.h\nfolly/experimental/coro/Sleep-inl.h -> folly/coro/Sleep-inl.h\nfolly/experimental/coro/SmallUnboundedQueue.h -> folly/coro/SmallUnboundedQueue.h\nfolly/experimental/coro/Task.h -> folly/coro/Task.h\nfolly/experimental/coro/TimedWait.h -> folly/coro/TimedWait.h\nfolly/experimental/coro/Timeout.h -> folly/coro/Timeout.h\nfolly/experimental/coro/Timeout-inl.h -> folly/coro/Timeout-inl.h\nfolly/experimental/coro/Traits.h -> folly/coro/Traits.h\nfolly/experimental/coro/Transform.h -> folly/coro/Transform.h\nfolly/experimental/coro/Transform-inl.h -> folly/coro/Transform-inl.h\nfolly/experimental/coro/UnboundedQueue.h -> folly/coro/UnboundedQueue.h\nfolly/experimental/coro/ViaIfAsync.h -> folly/coro/ViaIfAsync.h\nfolly/experimental/coro/WithAsyncStack.h -> folly/coro/WithAsyncStack.h\nfolly/experimental/coro/WithCancellation.h -> folly/coro/WithCancellation.h\nfolly/experimental/coro/BoundedQueue.h -> folly/coro/BoundedQueue.h\nfolly/experimental/coro/SharedPromise.h -> folly/coro/SharedPromise.h\nfolly/experimental/coro/Cleanup.h -> folly/coro/Cleanup.h\nfolly/experimental/coro/AutoCleanup-fwd.h -> folly/coro/AutoCleanup-fwd.h\nfolly/experimental/coro/AutoCleanup.h -> folly/coro/AutoCleanup.h\n```\n\nThis is a codemod. It was automatically generated and will be landed once it is approved and tests are passing in sandcastle.\nYou have been added as a reviewer by Sentinel or Butterfly.\n\nAutodiff project: dcoro\nAutodiff partition: fbcode.folly.io\nAutodiff bookmark: ad.dcoro.fbcode.folly.io\n\nReviewed By: yfeldblum, dtolnay\n\nDifferential Revision: D62684290\n\nfbshipit-source-id: 51c13265929709169e8f4d823bb9871808364eec","shortMessageHtmlLink":"Deshim coro in fbcode/folly/io"}},{"before":"5631fdca66cad4ab91420cfbadb6e03c722c877e","after":"58f15742af8c4aa087f66d46e91ca4c3407de220","ref":"refs/heads/main","pushedAt":"2024-09-14T00:21:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"fix non-constexpr path in span::size\n\nReviewed By: Gownta, Mizuchi\n\nDifferential Revision: D62653433\n\nfbshipit-source-id: 9420d40c1ca0666e53921cbae187746811d005ae","shortMessageHtmlLink":"fix non-constexpr path in span::size"}},{"before":"e49355c613317bd5cb0d90d5f409123b67bd231a","after":"5631fdca66cad4ab91420cfbadb6e03c722c877e","ref":"refs/heads/main","pushedAt":"2024-09-13T21:43:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"tryTo() is noexcept\n\nSummary:\nThe docs for `tryTo` indicate it that it is a non-throwing version of `to`. However, clang's `bugprone-exception-escape` analysis showed that callers of this function may in fact get an exception.\n\nFix this situation by marking `tryTo` as `noexcept`.\n\nReviewed By: yfeldblum\n\nDifferential Revision: D62518923\n\nfbshipit-source-id: 33cfcc9429734790f61f3d5d25b9637c440d8abf","shortMessageHtmlLink":"tryTo() is noexcept"}},{"before":"47590a322ce894fcfce8ec90947b31026664b1dc","after":"e49355c613317bd5cb0d90d5f409123b67bd231a","ref":"refs/heads/main","pushedAt":"2024-09-13T20:45:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add liboqs to getdeps\n\nSummary:\nX-link: https://github.com/facebookincubator/zstrong/pull/990\n\n* Add liboqs to getdeps\n* Add liboqs as dependency in fizz\n\nDifferential Revision: D62399390\n\nfbshipit-source-id: aca81633b6f35146d29a09a7ff899bddae32e14a","shortMessageHtmlLink":"Add liboqs to getdeps"}},{"before":"3f21ed6dd97f36ca6653b16d5b086b8b8a7efebc","after":"47590a322ce894fcfce8ec90947b31026664b1dc","ref":"refs/heads/main","pushedAt":"2024-09-13T17:43:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"coro toTaskInterruptOnCancel\n\nSummary: A conversion from `Future` to `Task`, which interrupts the `Future` when cancellation is requested.\n\nReviewed By: mpsrig\n\nDifferential Revision: D62595225\n\nfbshipit-source-id: afad94c08b659cd800c58e77e33ce28dd5e08835","shortMessageHtmlLink":"coro toTaskInterruptOnCancel"}},{"before":"c4e58444f9f1dd284a0f38dc6bf9b0158306723e","after":"3f21ed6dd97f36ca6653b16d5b086b8b8a7efebc","ref":"refs/heads/main","pushedAt":"2024-09-13T09:05:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"let Cursor::peek return span\n\nSummary:\nCurrently, `CursorBase::peek()` returns `pair<uint8_t const*, size_t>` and `CursorBase::peekView()` returns `basic_string_view<uint8_t>`. Consolidate them into `CursorBase::peek()` returning `span<uint8_t const>`.\n\nAs one motivation, libc++ v19 removes `basic_string_view<uint8_t>`.\n\nReviewed By: thevinster\n\nDifferential Revision: D62460851\n\nfbshipit-source-id: 72d567817faf778287594c10dfd7f6f379bf2446","shortMessageHtmlLink":"let Cursor::peek return span"}},{"before":"c9c2b90b20a301b8e09eaf195bcfd64675a816b3","after":"c4e58444f9f1dd284a0f38dc6bf9b0158306723e","ref":"refs/heads/main","pushedAt":"2024-09-13T07:00:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix data race in SingletonHolder<T>::hasLiveInstance\n\nSummary:\nhasLiveInstance() accesses instance_weak_ which is not safe to access concurrently with createInstance().\nIn all other places hasLiveInstance() is already called while holding the vault state lock or after switching state to shutdown (which prevents concurrent creation).\n\nlivingSingletonCount() should be performing similar synchronization as well.\n\nReviewed By: dsesh\n\nDifferential Revision: D62614961\n\nfbshipit-source-id: 7552e46fc12fb4e6e02c5094afb1d4a4e0b7804c","shortMessageHtmlLink":"Fix data race in SingletonHolder&lt;T&gt;::hasLiveInstance"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEuy_90wA","startCursor":null,"endCursor":null}},"title":"Activity · facebook/folly"}