Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protoboard: failure to implement function prototypes is only reported on plugin load #187

Open
vmatare opened this issue Dec 9, 2019 · 1 comment
Open

protoboard: failure to implement function prototypes is only reported on plugin load #187

vmatare opened this issue Dec 9, 2019 · 1 comment
Labels
pinned Issue will not be closed by stale bot

Comments

@vmatare
Copy link
Contributor

vmatare commented Dec 9, 2019

libfawkesprotoboard is linked with undefined symbols:

fawkes/src/libs/protoboard/Makefile

Line 47 in ef3c222

ALLOW_UNDEF_libfawkesprotoboard = 1

Because if this, if a user forgets to implement any of the declared (but unimplemented) functions, that error will only be reported on plugin load because symbol resolution is deferred until then.
@vmatare vmatare mentioned this issue Dec 9, 2019
Merged
@vmatare vmatare changed the title protoboard: failure to implement make_receiving_interfaces_map() is only reported on plugin load protoboard: failure to implement function prototypes is only reported on plugin load Dec 9, 2019
@stale
Copy link

stale bot commented Jan 8, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix We won't fix this issue label Jan 8, 2020
@morxa morxa added pinned Issue will not be closed by stale bot and removed wontfix We won't fix this issue labels Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pinned Issue will not be closed by stale bot
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@morxa @vmatare