FB14887376: AppStore.requestReview(in:) is not a complete alternative to the deprecated SKStoreReviewController.requestReview()

[sindresorhus]

• Date: 2024-08-22
• Resolution: Open
• Area: StoreKit
• OS: macOS 14.5
• Type: Incorrect/Unexpected Behavior

Description

SKStoreReviewController.requestReview() is deprecated in favor of AppStore.requestReview(in:). The problem is that AppStore.requestReview(in:) requires passing in a NSViewController, and in some contexts, this is not possible. For example, a menu bar app that only has a NSMenu when you click it. It has no NSViewController that could be passed in. I suggest making the controller parameter optional.