Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help needed improving Kanal #18

Open
fereidani opened this issue Nov 12, 2022 · 5 comments
Open

Help needed improving Kanal #18

fereidani opened this issue Nov 12, 2022 · 5 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed

Comments

@fereidani
Copy link
Owner

I open this issue for those kind people who are interested provide help to develop Kanal.

We need help in these areas:

  1. Auditing Kanal for UB and security-related issues.
  2. Writing tests for all library functions, in all cases. include cases that the function returns an error.
  3. Improving documentation
@fereidani fereidani added documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed labels Nov 12, 2022
@caass
Copy link

caass commented Feb 8, 2023

Hey, I'm interested in improving documentation. Do you have a general sense of what's needed or should I just check the codebase and start documenting?

@fereidani
Copy link
Owner Author

Hey @caass , Thank you, It would be nice.
I think my documentation is insufficient so a general overview would be nice.
Documentation could be in the style of Rust's own MPSC channel to help integrity between Kanal and Rust own documentation.
https://doc.rust-lang.org/src/std/sync/mpsc/mod.rs.html#1-126
Please use wrap_comments = true in your rustfmt.toml with nightly rustfmt.

@Originalimoc
Copy link

Originalimoc commented May 29, 2023

bounded_async is indeed fast, use bound size 40 with 1500 bytes data in spsc setup gets 23Million pks compare to 4.9M tokio::mpsc. Most gain from no syscall(this includes lock contention). will keep a close eye on unsafe part code.

Edit/Note: 1p2c reduced to 11M from 1p1c 23M, expected bc lock, data integrity passed plus no message loss so far.
Edit2: 1p1c, unbounded_async, only 1.5M, is it expected?

@fereidani
Copy link
Owner Author

@Originalimoc unbounded_async should not be much different from bounded 40, it could be related to your software design because in our benchmarks they are pretty close, and sometimes unbounded is faster than bounded.

@Originalimoc
Copy link

Originalimoc commented Jun 7, 2023

It's just a dumb two-task tokio async test using unbounded_async, one loop send a bunch one for recv.await, then after all received side calculate count divided by time elapsed, multicore AMD 2 CCD system default tokio runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants