Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomActor: rename "prefix" in panel to "typeName" #8

Open
hallvors opened this issue Jul 29, 2016 · 2 comments
Open

CustomActor: rename "prefix" in panel to "typeName" #8

hallvors opened this issue Jul 29, 2016 · 2 comments

Comments

@hallvors
Copy link
Contributor

As I've just tried to write an extension based on this example, one of the gotchas that took a while to figure out was that the value for prefix set on line 122 in myPanel.js must match the value of typeName set on line 42 in myActor.js.

If these do not match, registering the actor fails:

Handler function DebuggerClient.requester request callback threw an exception: Error: Can't manage front without an actor ID

I suggest changing to work "prefix" to "typeName" to make it at least a bit clearer that these strings are related.

@hallvors
Copy link
Contributor Author

@janodvarko - thoughts?

@janodvarko
Copy link
Member

janodvarko commented Aug 8, 2016

(just got back from my vacation)

@hallvors: yes, this is nice improvement.

Honza

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants