Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOMContentLoaded listener in popup-frame-script.js #59

Open
janodvarko opened this issue Mar 26, 2015 · 1 comment
Open

DOMContentLoaded listener in popup-frame-script.js #59

janodvarko opened this issue Mar 26, 2015 · 1 comment

Comments

@janodvarko
Copy link
Member

DOMContentLoaded listener in popup-frame-script.js needs to check that the window has the expected URL, or at least to unregister itself after the first response, so that it doesn't wind up injecting a privileged function into a remote document if the window somehow navigates somewhere unexpected.

(from AMO review)

Honza

@janodvarko
Copy link
Member Author

@aliuk2012 This came from the AMO reviewer, would you be interested to take a look?

Honza

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant