Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Text in other languages was removed from anchors #11151

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

AmosHuKe
Copy link
Contributor

@AmosHuKe AmosHuKe commented Sep 17, 2024

Description of what this PR is changing or adding, and why:

Markdown

## Hello! 你好! हैलो مرحبا -

If the header contains text in other languages, those languages are removed:

<div class="header-wrapper">
  <h2 id="hello">Hello! 你好! हैलो مرحبا -</h2>
  <a class="heading-link" href="#hello" aria-label="Link to 'Hello! 你好! हैलो مرحبا -' section">#</a>
</div>

The expected HTML looks like this:

<div class="header-wrapper">
  <h2 id="hello-你好-हल-مرحبا">Hello! 你好! हैलो مرحبا -</h2>
  <a class="heading-link" href="#hello-你好-हल-مرحبا" aria-label="Link to 'Hello! 你好! हैलो مرحبا -' section">#</a>
</div>

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@AmosHuKe AmosHuKe requested review from sfshaza2, parlough and a team as code owners September 17, 2024 07:51
@AmosHuKe
Copy link
Contributor Author

CC @parlough 😄

@sfshaza2
Copy link
Contributor

/gcbrun

@flutter-website-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit 1fee75b):

https://flutter-docs-prod--pr11151-patch-anchors-1-pac6eiaj.web.app

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't consider this, thanks!

@parlough parlough merged commit 6e1bf00 into flutter:main Sep 18, 2024
9 checks passed
@AmosHuKe AmosHuKe deleted the patch-anchors-1 branch September 19, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants