Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkins version update: allow unicode encoding #142

Open
PhilTaken opened this issue Dec 12, 2023 · 0 comments
Open

Jenkins version update: allow unicode encoding #142

PhilTaken opened this issue Dec 12, 2023 · 0 comments
Assignees

Comments

@PhilTaken
Copy link
Member

stdout = stdout.decode("ascii")

In cases where the remote branch name includes a unicode symbol (e.g. german umlauts) this line raises an unexpected error:

Traceback (most recent call last):
  File "<redacted>/./.appenv/9ac02331/bin/jenkins", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "<redacted>/.appenv/9ac02331/lib/python3.11/site-packages/batou_ext/jenkins.py", line 137, in main
    return args.func(**func_args)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "<redacted>/.appenv/9ac02331/lib/python3.11/site-packages/batou_ext/jenkins.py", line 104, in set_versions
    vu()
  File "<redacted>/.appenv/9ac02331/lib/python3.11/site-packages/batou_ext/jenkins.py", line 51, in __call__
    self.update(service, version)
  File "<redacted>/.appenv/9ac02331/lib/python3.11/site-packages/batou_ext/jenkins.py", line 65, in update
    func(service, version, args)
  File "<redacted>/.appenv/9ac02331/lib/python3.11/site-packages/batou_ext/jenkins.py", line 68, in update_git
    resolved = git_resolve(self.config.get(service, "url"), version)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<redacted>/.appenv/9ac02331/lib/python3.11/site-packages/batou_ext/jenkins.py", line 30, in git_resolve
    stdout = stdout.decode("ascii")
             ^^^^^^^^^^^^^^^^^^^^^^
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 85: ordinal not in range(128)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants