Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the electron app should package the cli #30

Open
andrew opened this issue Feb 2, 2021 · 2 comments
Open

the electron app should package the cli #30

andrew opened this issue Feb 2, 2021 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@andrew
Copy link
Member

andrew commented Feb 2, 2021

Currently you can only use the npm module foragepm as the cli (unless you're running directly from source).

It'd be great to be able to add a foragepm command line that points at the electron app itself so you don't need node installed to use the cli if you have the electron app installed.

@andrew andrew added the enhancement New feature or request label Feb 2, 2021
@andrew andrew added the help wanted Extra attention is needed label Apr 21, 2021
@andrew andrew added this to the 0.1.0 milestone Jun 2, 2021
@andrew
Copy link
Member Author

andrew commented Jun 2, 2021

This article has some pointers on how to get the electron app to recognize if it's being ran from the cli. Then the menu bar will need a prompt to install a symlink to the app into the terminal, ipfs-desktop can be an example, adding windows support makes it more complex: https://github.com/ipfs/ipfs-desktop/tree/main/src/ipfs-on-path

An alternative approach may be to have the electron app prompt to install the command line node module, again ipfs-desktop has an example: https://github.com/ipfs/ipfs-desktop/tree/main/src/npm-on-ipfs

@olizilla
Copy link
Collaborator

olizilla commented Jun 3, 2021

I think having a menu option the user can click to get the cli is a reasonable pattern. I kinda prefer to have the cli tool and the app always be at the same version / be holistically in sync. But a prompt that just says "go do npm i -g foragepm" is less work to implement, and may appeal to the kinds of folks who would also be interested in running the cli anyway (at this early stage)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants