fix: Github API endpoint #14874
Merged
fix: Github API endpoint #14874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pateljannat
requested review from
gavindsouza,
leela and
surajshetty3416
as code owners
pateljannat
requested review from
a team
and removed request for
a team,
leela and
gavindsouza
Codecov Report
@@ Coverage Diff @@
## develop #14874 +/- ##
===========================================
+ Coverage 49.57% 50.19% +0.61%
===========================================
Files 748 744 -4
Lines 65606 65469 -137
Branches 5485 5428 -57
===========================================
+ Hits 32527 32862 +335
+ Misses 29171 28746 -425
+ Partials 3908 3861 -47
Flags with carried forward coverage won't be shown. Click here to find out more. |
surajshetty3416
requested changes
Nov 8, 2021
There was a problem hiding this comment.
@pateljannat I encountered the following error while using Github Login
Traceback (most recent call last):
File "/Users/sps/benches/develop/apps/frappe/frappe/app.py", line 66, in application
response = frappe.api.handle()
File "/Users/sps/benches/develop/apps/frappe/frappe/api.py", line 54, in handle
return frappe.handler.handle()
File "/Users/sps/benches/develop/apps/frappe/frappe/handler.py", line 31, in handle
data = execute_cmd(cmd)
File "/Users/sps/benches/develop/apps/frappe/frappe/handler.py", line 67, in execute_cmd
return frappe.call(method, **frappe.form_dict)
File "/Users/sps/benches/develop/apps/frappe/frappe/__init__.py", line 1213, in call
return fn(*args, **newargs)
File "/Users/sps/benches/develop/apps/frappe/frappe/www/login.py", line 85, in login_via_github
login_via_oauth2("github", code, state)
File "/Users/sps/benches/develop/apps/frappe/frappe/utils/oauth.py", line 109, in login_via_oauth2
login_oauth_user(info, provider=provider, state=state)
File "/Users/sps/benches/develop/apps/frappe/frappe/utils/oauth.py", line 186, in login_oauth_user
if update_oauth_user(user, data, provider) is False:
File "/Users/sps/benches/develop/apps/frappe/frappe/utils/oauth.py", line 267, in update_oauth_user
user.set_social_login_userid(provider, userid=data["id"], username=data.get("login"))
KeyError: 'id'
Note: I did regular sign up (without Github) but used Github to sign in.
|
@pateljannat can you also add test cases to validate these changes? |
surajshetty3416
approved these changes
Nov 10, 2021
|
@Mergifyio backport version-13-hotfix |
✅ Backports have been created
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: fossunited/mon_school#72 and #14810
Issue:
Fix: