Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frappe errors show up in modal #89

Open
nikochiko opened this issue Jan 10, 2022 · 0 comments
Open

Frappe errors show up in modal #89

nikochiko opened this issue Jan 10, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@nikochiko
Copy link
Contributor

Describe the bug
Frappe uses msgprint to send errors sometimes and that by default shows in a modal on the page. This isn't always desirable or foreseen as the method to show modal is not called directly from code written for some method.

This was one of the concerns in #86

To Reproduce
Steps to reproduce the behavior: #86 (comment)

Expected behavior
Some errors should go to the modal while some may need handling.

Screenshots

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@nikochiko nikochiko added the bug Something isn't working label Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant