Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce option for sending "reschedule_interview" mails or not #1945

Open
0xD0M1M0 opened this issue Jul 3, 2024 · 2 comments · May be fixed by #1946
Open

Introduce option for sending "reschedule_interview" mails or not #1945

0xD0M1M0 opened this issue Jul 3, 2024 · 2 comments · May be fixed by #1946
Labels
feature-request

Comments

@0xD0M1M0
Copy link

0xD0M1M0 commented Jul 3, 2024

Is your feature request related to a problem? Please describe.

While scheduling an interview with an applicant no e-mail is send, but when a rescheduling of the interview takes place an e-mail is always send even to the interviewee.

Describe the solution you'd like

I would like to choose in the HR options if I want an e-mail of a rescheduled interview to be send or not.

The function:

hrms/hrms/hr/doctype/interview/interview.py

Line 84 in 8d8ce3e

def reschedule_interview(self, scheduled_on, from_time, to_time):

needs to be extended with something similiar to:

hrms/hrms/hr/doctype/interview/interview.py

Lines 211 to 220 in 8d8ce3e

def send_interview_reminder():
reminder_settings = frappe.db.get_value(
"HR Settings",
"HR Settings",
["send_interview_reminder", "interview_reminder_template", "hiring_sender_email"],
as_dict=True,
)
if not cint(reminder_settings.send_interview_reminder):
return

and the option needs to be added to the "hr_settings" similar to:

hrms/hrms/hr/doctype/hr_settings/hr_settings.json

Line 38 in 8d8ce3e

"send_interview_reminder",

and

hrms/hrms/hr/doctype/hr_settings/hr_settings.json

Lines 190 to 195 in 8d8ce3e

{
"default": "0",
"fieldname": "send_interview_reminder",
"fieldtype": "Check",
"label": "Send Interview Reminder"
},

Describe the alternatives you've considered

No response

Additional context

No response
@niraj2477
Copy link
Contributor

How about if we allow setting up the template for notification too?!

@0xD0M1M0
Copy link
Author

0xD0M1M0 commented Jul 4, 2024

Sure, I would like that. I can't do it so and my first concern is that it doesn't send an e-mail at all.

@niraj2477 niraj2477 linked a pull request Jul 4, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Allow optionally send reminder mail for rescheduled interview niraj2477/hrms
2 participants
@niraj2477 @0xD0M1M0