Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use cargo macros across the repo #3111

Open
joebonrichie opened this issue Jun 27, 2024 · 1 comment · May be fixed by #3629
Open

chore: Use cargo macros across the repo #3111

joebonrichie opened this issue Jun 27, 2024 · 1 comment · May be fixed by #3629
Labels
Chore Not a feature or a bug Good First Issue Issue that is good for someone new to the Solus project to try to tackle Tooling Tools and scripts

Comments

@joebonrichie
Copy link
Contributor

joebonrichie commented Jun 27, 2024

ypkg now provides standardized cargo macros for rust packages:

%cargo_fetch, %cargo_build, %cargo_install, %cargo_test

Note that %cargo_install can take an additional argument if the binary name does not match the package name e.g. %cargo_install mycustombinary

See d44c520 as an example

For an new packagers wishing to learn the Solus packaging system, this would be a good opportunity to do so. See the full list yourself by installing the ripgrep package and running the following ripgrep (rg) command from the root of this repository:

rg --files-with-matches "cargo build" -g '*package.yml' | sort

The list

37 21 7 2 packages left

  • juliaup
  • rav1el
@joebonrichie joebonrichie added Chore Not a feature or a bug Good First Issue Issue that is good for someone new to the Solus project to try to tackle Tooling Tools and scripts labels Jun 27, 2024
@joebonrichie joebonrichie pinned this issue Jun 27, 2024
@androidnisse
Copy link
Contributor

The macro for install can be improved, see #3230

malfisya added a commit that referenced this issue Jul 14, 2024
**Summary**

- Add appstream metainfo (Part of #1389)
- Use cargo macros (Part of #3111)
@malfisya malfisya mentioned this issue Jul 14, 2024
1 task
algent-al added a commit that referenced this issue Jul 14, 2024
**Summary**

- Add appstream metainfo (Part of #1389)
- Use cargo macros (Part of #3111)

**Test Plan**

<!-- Short description of how the package was tested -->
Verify metainfo with appstream-builder --packages-dir=. --include-failed
-v

**Checklist**

- [x] Package was built and tested against unstable
A108384 added a commit to A108384/packages that referenced this issue Aug 17, 2024
**Summary**
- Rebuild using new cargo macros [getsolus#3111](getsolus#3111)
- Resolves build issue (getsolus#3306)[getsolus#3306]
A108384 added a commit to A108384/packages that referenced this issue Aug 17, 2024
**Summary**
- Rebuild using new cargo macros [3111](getsolus#3111)
- Resolves build issue [3306](getsolus#3306)
A108384 added a commit to A108384/packages that referenced this issue Aug 17, 2024
**Summary**
- Rebuild using new cargo macros (getsolus#3111)
- Resolves build issue (getsolus#3306)
algent-al added a commit that referenced this issue Aug 17, 2024
**Summary**
- Rebuild using new cargo macros
[#3111](#3111)
- Resolves build issue
[#3306](#3306)

**Test Plan**
- [x] Successfully rebuild and install new package
- [x] Successfully validate enhanced ls ouput

**Checklist**
- [x] Package was built and tested against unstable
BoatyPillow added a commit to BoatyPillow/packages that referenced this issue Aug 20, 2024
**Summary**
Updated juliaup to 1.17.2 and resolves getsolus#3111 by updating to the new cargo macros supported by ypkg

Release notes can be found [here](https://github.com/JuliaLang/juliaup/releases/tag/v1.17.2)
@BoatyPillow BoatyPillow linked a pull request Aug 20, 2024 that will close this issue
1 task
davidjharder added a commit that referenced this issue Aug 31, 2024
EbonJaeger added a commit that referenced this issue Aug 31, 2024
**Summary**

- Part of #3111
- Resolves #3320

**Test Plan**

- Look at stocks

**Checklist**

- [x] Package was built and tested against unstable
davidjharder added a commit that referenced this issue Sep 3, 2024
**Summary**

- Changelog [here](https://github.com/Nukesor/pueue/releases/tag/v3.4.1)

**Packaging**

- Switch to cargo macros
- Part of #3111
HarveyDevel added a commit that referenced this issue Sep 4, 2024
**Summary**

- Changelog [here](https://github.com/Nukesor/pueue/releases/tag/v3.4.1)

**Packaging**

- Switch to cargo macros
- Part of #3111

**Test Plan**

- Start pueue and queue a command

**Checklist**

- [x] Package was built and tested against unstable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore Not a feature or a bug Good First Issue Issue that is good for someone new to the Solus project to try to tackle Tooling Tools and scripts
Projects
Status: Triage
Development

Successfully merging a pull request may close this issue.

2 participants