Skip to content

Binary test file is treated as valid contributions, giving +400000 lines of code in pull request. #5164

Answered by lildude
ni4 asked this question in Classification
Discussion options

You must be logged in to vote

PR is still displaying +408171 lines of code in the diff.

No it's not. It's reporting "changes":

... which is not necessarily the number of lines changed and also has nothing to do with Linguist, so anything Linguist related in the .gitattributes will have no effect at all.

It's important to remember that you're essentially looking at a nice friendly web view of git diff in the "Files changed" tab of a PR and that's where the number of "changes" comes from as we can see if we look at the diff using git alone:

$ git clone -q [email protected]:rnpgp/rnp.git
$ cd rnp
$ git switch ni4-oss-fuzz-26318-out-of-memory
Switched to branch 'ni4-oss-fuzz-26318-out-of-memory'
Your branch is up to date …

Replies: 4 comments

Comment options

You must be logged in to vote
0 replies
Answer selected by lildude
Comment options

You must be logged in to vote
0 replies
Comment options

You must be logged in to vote
0 replies
Comment options

You must be logged in to vote
0 replies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
Converted from issue

This discussion was converted from issue #5131 on January 22, 2021 17:39.