Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing cd after commiting files? #731

Open
Bluefissure opened this issue Nov 13, 2022 · 1 comment
Open

Missing cd after commiting files? #731

Bluefissure opened this issue Nov 13, 2022 · 1 comment

Comments

@Bluefissure
Copy link
Contributor

Got confused by https://github.com/goatcorp/DalamudPluginsD17/blob/71c4e2d/.github/workflows/push.yml#L78, is it trying to cd back to the workspace?

It seems to fail the task but the workflow will continue (because of continue-on-error: true):
https://github.com/goatcorp/DalamudPluginsD17/actions/runs/3452829814/jobs/5762986376#step:9:13
image
image
@NotNite
Copy link
Contributor

NotNite commented Nov 13, 2022

Probably can be safely removed? I didn't write this line but I don't think we need it, because it doesn't do anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Bluefissure @NotNite