Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention common failure cases #795

Open
philpax opened this issue Nov 27, 2022 · 1 comment
Open

Mention common failure cases #795

philpax opened this issue Nov 27, 2022 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@philpax
Copy link
Contributor

philpax commented Nov 27, 2022

  • Owners needs to be the GitHub username the PR is being submitted with
  • Need to ensure you have a lockfile present
  • Need to make sure you're not using Windows Forms or similar - for audio, use NAudio (?)
  • Need to make sure you have DalamudPackager as a dependency and that it's set up correctly in your solution
  • Internal name must be the same as the folder used for the plugin in the repo

Only one I'm not sure about is the audio. @kalilistic can you tell me what the correct fix for that is?

@philpax philpax added the documentation Improvements or additions to documentation label Nov 27, 2022
@kalilistic
Copy link
Contributor

You can't use NAudio.Wave since it's dependent on NAudio.WinForms. This causes a problem with dalamud's gha since you can't build winforms on linux. Instead, you can use NAudio.Core and NAudio.Wasapi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants