Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort PRs with a single platform: label under "Porting:", even if not using topic:porting label #9

Open
akien-mga opened this issue Jun 21, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@akien-mga
Copy link
Member

akien-mga commented Jun 21, 2023

This is up for discussion, but when I was doing the changelogs manually, I would sort any platform-specific PR under Platforms/Porting, even if it doesn't explicitly have the topic:porting label.

Here's an example from 4.1-beta3 of a topic:rendering PR godotengine/godot#78235 which is Windows specific, and would IMO best be listed as "Porting: Windows: Fix for Win+M crashing the editor"

I don't know yet if it would always be the right decision though. For example it's up for debate when a PR like godotengine/godot#78120 should go under "Porting: Windows:" or "Buildsystem:". Intuitively I would say "Buildsystem:" is better, but maybe that's the only exception to the above rule?

@akien-mga akien-mga added the enhancement New feature or request label Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant