Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling for Flux Artifact #20921

Open
jonesbusy opened this issue Sep 12, 2024 · 2 comments
Open

Better handling for Flux Artifact #20921

jonesbusy opened this issue Sep 12, 2024 · 2 comments
Assignees
Labels
kind/requirement New feature or idea on top of harbor

Comments

@jonesbusy
Copy link

Hi,

This is an idea for Flux artifacts

We are using Harbor to store Flux OCI artifacts. When checking on the UI it's not clear it's Flux Artifact because they fall under the default type

flux_manifest

According to https://fluxcd.io/flux/cheatsheets/oci-artifacts/

Flux OCI Artifact set the following types

artifact media type application/vnd.oci.image.manifest.v1+json
config media type application/vnd.cncf.flux.config.v1+json
content media type application/vnd.cncf.flux.content.v1.tar+gzip

Maybe just adding a Flux logo would be enough ? for those media types ?

@chlins chlins added the kind/requirement New feature or idea on top of harbor label Sep 12, 2024
@reasonerjt
Copy link
Contributor

For Harbor to support new types of Artifacts there are two options:

  1. Update Harbor's code to add a new processor to support new artifact
  2. The OCI artifact can be bundled in a certain way that is recognizable by Harbor, see this proposal

Can we proceed with option 2)?

@jonesbusy
Copy link
Author

Thanks for your answer. I was not aware of this proposal

Checking at a flux manifest

{
  "schemaVersion": 2,
  "mediaType": "application/vnd.oci.image.manifest.v1+json",
  "config": {
    "mediaType": "application/vnd.cncf.flux.config.v1+json",
    "size": 233,
    "digest": "sha256:59cb5a5df1278e0e4149b68bb0c57d920c2e6efe6fe65e0e1988293269a6cb9c"
  },
  "layers": [
    {
      "mediaType": "application/vnd.cncf.flux.content.v1.tar+gzip",
      "size": 337,
      "digest": "sha256:540013791074130f25c437ff9a40881c1a72fe94b6c89840b788f58dc36936e5"
    }
  ],
  "annotations": {
    "org.opencontainers.image.created": "2024-09-19T02:00:06Z",
    "org.opencontainers.image.revision": "staging@sha1:5192698a9835579e136ab2b656f49e83d113c36d  services.json",
    "org.opencontainers.image.source": "****"
  }
}

So if we go with 2) it means the flux client must send this png layer ?

I understand for propriatary artifact, but I would argue that 1) is also a solution since Flux is also a CNCF graduated like Helm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/requirement New feature or idea on top of harbor
Projects
None yet
Development

No branches or pull requests

3 participants