Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to provide config.toml in helm chart #22

Open
hypnoglow opened this issue Sep 30, 2019 · 0 comments
Open

Add possibility to provide config.toml in helm chart #22

hypnoglow opened this issue Sep 30, 2019 · 0 comments

Comments

@hypnoglow
Copy link

Is your feature request related to a problem? Please describe.

Currently there is no way to provide custom config.toml file to Athens when using helm chart. All configuration is done via environment variables. However, in some cases config file is preferable. And in some edge cases environment variables won't work (for example, see gomods/athens#1404 )

Describe the solution you'd like

We should provide configuration file with customization possibility in helm chart. This can be done via exposing a value in values-file, e.g.:

config.toml: |-
    GoEnv = "development"
    GoBinaryEnvVars = ["GOPROXY=direct"]

Default value should be equal to the default config which is included in the docker image.

Another option would be allowing extraVolumes and extraVolumeMounts, as done in many popular helm charts (e.g. vault. This way user is responsible for providing their config files, placing them in correct locations and mounting properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant