Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support download mode file in helm chart #8

Open
DrPsychick opened this issue Mar 12, 2023 · 3 comments
Open

Support download mode file in helm chart #8

DrPsychick opened this issue Mar 12, 2023 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone
0.6.0 - back to a...

Comments

@DrPsychick
Copy link
Member

from #1724
@DrPsychick
Copy link
Member Author

If we add this, I think the chart should support all DownloadMode options.
https://github.com/gomods/athens/blob/43ee4259e31561f7167d7aadbd80d9a2d7884fd8/config.dev.toml#L248

The file: does not need to be explicitly supported in the Chart as a ConfigMap, as one could then use custom:<b64-encoded-hcl> or provide a existingConfigMap which contains the file.

@DrPsychick DrPsychick added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Mar 17, 2023
@dsloanather
Copy link

Any progress on this?

@DrPsychick
Copy link
Member Author

This is one of the things I would tackle next, first I want to focus efforts on getting Athens up to date again (release v0.12.0).

I'm happy to review if you're willing to contribute a PR.

@DrPsychick DrPsychick mentioned this issue Apr 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
0.6.0 - back to awesomeness
Development

No branches or pull requests
2 participants
@DrPsychick @dsloanather