{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":143455116,"defaultBranch":"main","name":"filament","ownerLogin":"google","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2018-08-03T17:26:00.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/1342004?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1726873659.0","currentOid":""},"activityList":{"items":[{"before":null,"after":"91e8c53841a985e84500d8d507442e18361f9bfb","ref":"refs/heads/ma/commands-size","pushedAt":"2024-09-20T23:07:39.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"pixelflinger","name":"Mathias Agopian","path":"/pixelflinger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1240896?s=80&v=4"},"commit":{"message":"update the max command size\n\nthis value needs to be updated each time the execute inner loop changes.","shortMessageHtmlLink":"update the max command size"}},{"before":"889319b56a5412798c975642680adb05fd0310f4","after":null,"ref":"refs/heads/pf/make-windows-build-faster","pushedAt":"2024-09-20T00:19:17.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"poweifeng","name":"Powei Feng","path":"/poweifeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/48371888?s=80&v=4"}},{"before":"c5fe185834466e12c686c88a2c2f7f2654b34905","after":"67f37d4c156bd7d38cbb3210f540ad2eec692236","ref":"refs/heads/main","pushedAt":"2024-09-20T00:19:16.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"poweifeng","name":"Powei Feng","path":"/poweifeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/48371888?s=80&v=4"},"commit":{"message":"github: make windows build use all available cores\n\n- Also used a smaller runner as the gains from the 32-core was\n  not efficient when comparing output times.\n- Clean-up:\n    - Rename the android continuous to a proper name\n    - set 'echo on' for the Windows release build so we'll know\n      why the output asset does not get \"moved\" correclty.","shortMessageHtmlLink":"github: make windows build use all available cores"}},{"before":"fb7ef18baf9096ff8de012ab8131022a89163da5","after":"889319b56a5412798c975642680adb05fd0310f4","ref":"refs/heads/pf/make-windows-build-faster","pushedAt":"2024-09-20T00:04:13.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"poweifeng","name":"Powei Feng","path":"/poweifeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/48371888?s=80&v=4"},"commit":{"message":"Merge branch 'main' into pf/make-windows-build-faster","shortMessageHtmlLink":"Merge branch 'main' into pf/make-windows-build-faster"}},{"before":"963aaf6d9adb5c66ab7215799f1f999791c78ec8","after":"fb7ef18baf9096ff8de012ab8131022a89163da5","ref":"refs/heads/pf/make-windows-build-faster","pushedAt":"2024-09-20T00:04:04.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"poweifeng","name":"Powei Feng","path":"/poweifeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/48371888?s=80&v=4"},"commit":{"message":"github: make windows build use all available cores\n\n- Also used a smaller runner as the gains from the 32-core was\n  not efficient when comparing output times.\n- Clean-up:\n    - Rename the android continuous to a proper name\n    - set 'echo on' for the Windows release build so we'll know\n      why the output asset does not get \"moved\" correclty.","shortMessageHtmlLink":"github: make windows build use all available cores"}},{"before":null,"after":"922ecaf3e6899ee91b64776517377c2d15baccc4","ref":"refs/heads/ma/mi","pushedAt":"2024-09-19T23:53:02.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"pixelflinger","name":"Mathias Agopian","path":"/pixelflinger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1240896?s=80&v=4"},"commit":{"message":"make the default MaterialInstance just a regular one\n\nThe default MaterialInstance is not special anymore. It's not even\ncreated until getDefaultInstance() is called.\nMaterial just keeps a pointer to it after that and it's tracked by\nEngine just like any other instance.","shortMessageHtmlLink":"make the default MaterialInstance just a regular one"}},{"before":"d4331df859b67b16528a88a24322a17162603161","after":"976bd255a50934c55e74ba2a8382c1ee5029d6ca","ref":"refs/heads/ma/descriptor-sets-1.54.4","pushedAt":"2024-09-19T23:18:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bejado","name":"Ben Doherty","path":"/bejado","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5298046?s=80&v=4"},"commit":{"message":"Debugging improvements","shortMessageHtmlLink":"Debugging improvements"}},{"before":"d97330510f9dfe31c4762e0843aeef74ff076aea","after":null,"ref":"refs/heads/ma/fix-web","pushedAt":"2024-09-19T22:57:56.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"pixelflinger","name":"Mathias Agopian","path":"/pixelflinger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1240896?s=80&v=4"}},{"before":"cc8c4c12a20368815b30173a42d4ffe147aca362","after":"d4331df859b67b16528a88a24322a17162603161","ref":"refs/heads/ma/descriptor-sets-1.54.4","pushedAt":"2024-09-19T22:57:55.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"pixelflinger","name":"Mathias Agopian","path":"/pixelflinger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1240896?s=80&v=4"},"commit":{"message":"fix a typo that broke WebGL","shortMessageHtmlLink":"fix a typo that broke WebGL"}},{"before":"c38d50215450a79fe59e480e68646801b788abb4","after":null,"ref":"refs/heads/ma/surfaceless","pushedAt":"2024-09-19T22:56:58.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"pixelflinger","name":"Mathias Agopian","path":"/pixelflinger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1240896?s=80&v=4"}},{"before":"4c5261106aac0d24016a4d779a4da49e912bc3b4","after":"c5fe185834466e12c686c88a2c2f7f2654b34905","ref":"refs/heads/main","pushedAt":"2024-09-19T22:56:56.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"pixelflinger","name":"Mathias Agopian","path":"/pixelflinger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1240896?s=80&v=4"},"commit":{"message":"KHR_create_context doesn't, in fact, imply HR_surfaceless_context","shortMessageHtmlLink":"KHR_create_context doesn't, in fact, imply HR_surfaceless_context"}},{"before":null,"after":"d97330510f9dfe31c4762e0843aeef74ff076aea","ref":"refs/heads/ma/fix-web","pushedAt":"2024-09-19T22:56:12.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"pixelflinger","name":"Mathias Agopian","path":"/pixelflinger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1240896?s=80&v=4"},"commit":{"message":"fix a typo that broke WebGL","shortMessageHtmlLink":"fix a typo that broke WebGL"}},{"before":null,"after":"cc8c4c12a20368815b30173a42d4ffe147aca362","ref":"refs/heads/ma/descriptor-sets-1.54.4","pushedAt":"2024-09-19T21:01:02.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"pixelflinger","name":"Mathias Agopian","path":"/pixelflinger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1240896?s=80&v=4"},"commit":{"message":"Merge remote-tracking branch 'origin/release' into ma/descriptor-sets-1.54.4","shortMessageHtmlLink":"Merge remote-tracking branch 'origin/release' into ma/descriptor-sets…"}},{"before":"0d19491897532617b36ee627f3b1d4b629edfd4f","after":null,"ref":"refs/heads/ma/fix-material-fixup","pushedAt":"2024-09-19T20:55:07.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"pixelflinger","name":"Mathias Agopian","path":"/pixelflinger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1240896?s=80&v=4"}},{"before":"1ed477745cdac106e57237ee991243888861f62f","after":"d83485dec8469ed1b34e1b901e1630628446b778","ref":"refs/heads/ma/descriptor-sets-1.54.3","pushedAt":"2024-09-19T20:55:05.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"pixelflinger","name":"Mathias Agopian","path":"/pixelflinger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1240896?s=80&v=4"},"commit":{"message":"better fix for fixing up missing samplers\n\nthe previous fix prevented \"commit\" to patch the samplers\nthat use a texture with a volatile handle.\n\nthe proper fix is to patch them first, and then see if some are still\nmissing, in which case we use a dummy texture.","shortMessageHtmlLink":"better fix for fixing up missing samplers"}},{"before":null,"after":"c38d50215450a79fe59e480e68646801b788abb4","ref":"refs/heads/ma/surfaceless","pushedAt":"2024-09-19T20:52:24.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"pixelflinger","name":"Mathias Agopian","path":"/pixelflinger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1240896?s=80&v=4"},"commit":{"message":"KHR_create_context doesn't, in fact, imply HR_surfaceless_context","shortMessageHtmlLink":"KHR_create_context doesn't, in fact, imply HR_surfaceless_context"}},{"before":"606e73e75755049a28b209b16b178cab00031e95","after":"963aaf6d9adb5c66ab7215799f1f999791c78ec8","ref":"refs/heads/pf/make-windows-build-faster","pushedAt":"2024-09-19T19:33:02.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"poweifeng","name":"Powei Feng","path":"/poweifeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/48371888?s=80&v=4"},"commit":{"message":"github: make windows build use all available cores\n\n- Also used a smaller runner as the gains from the 32-core was\n  not efficient when comparing output times.\n- Clean-up:\n    - Rename the android continuous to a proper name\n    - set 'echo on' for the Windows release build so we'll know\n      why the output asset does not get \"moved\" correclty.","shortMessageHtmlLink":"github: make windows build use all available cores"}},{"before":"7ad0bba7a28c05556ddc2d214ba0a211a3661dad","after":"606e73e75755049a28b209b16b178cab00031e95","ref":"refs/heads/pf/make-windows-build-faster","pushedAt":"2024-09-19T18:44:55.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"poweifeng","name":"Powei Feng","path":"/poweifeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/48371888?s=80&v=4"},"commit":{"message":"github: make windows build use all available cores","shortMessageHtmlLink":"github: make windows build use all available cores"}},{"before":"fad81e359b85635b384991e7b90e3fc8edc5f160","after":"0d19491897532617b36ee627f3b1d4b629edfd4f","ref":"refs/heads/ma/fix-material-fixup","pushedAt":"2024-09-19T18:27:43.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"pixelflinger","name":"Mathias Agopian","path":"/pixelflinger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1240896?s=80&v=4"},"commit":{"message":"better fix for fixing up missing samplers\n\nthe previous fix prevented \"commit\" to patch the samplers\nthat use a texture with a volatile handle.\n\nthe proper fix is to patch them first, and then see if some are still\nmissing, in which case we use a dummy texture.","shortMessageHtmlLink":"better fix for fixing up missing samplers"}},{"before":"936e7e28f6740a3c42031c892bdbe0fb74f18395","after":"7ad0bba7a28c05556ddc2d214ba0a211a3661dad","ref":"refs/heads/pf/make-windows-build-faster","pushedAt":"2024-09-19T18:26:48.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"poweifeng","name":"Powei Feng","path":"/poweifeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/48371888?s=80&v=4"},"commit":{"message":"github: make windows build use all available cores","shortMessageHtmlLink":"github: make windows build use all available cores"}},{"before":"130b6e9181687ab810fabad5f7301d368bcebd2c","after":null,"ref":"refs/heads/ma/fix-descriptor-set-layout-mismatch","pushedAt":"2024-09-19T18:25:49.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"pixelflinger","name":"Mathias Agopian","path":"/pixelflinger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1240896?s=80&v=4"}},{"before":"3239d8ce577608fd94b347762260aa5228cff278","after":"1ed477745cdac106e57237ee991243888861f62f","ref":"refs/heads/ma/descriptor-sets-1.54.3","pushedAt":"2024-09-19T18:25:47.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"pixelflinger","name":"Mathias Agopian","path":"/pixelflinger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1240896?s=80&v=4"},"commit":{"message":"fix fragment/vertex shader descriptor set layout mismatch (#8140)\n\n* fix fragment/vertex shader descriptor set layout mismatch\r\n\r\nThe SSR variant uses a custom fragment shader but the generic vertex\r\nshader. For this reason their descriptor set layout for the \"per view\"\r\nset end-up being different (the fragment shader one has less\r\ndescriptors in it and the descriptor itself is create from the SSR\r\nvariant data).  In the end, we end up with a descriptor set that's too\r\nsmall for the vertex shader and Metal was rightly complaining.\r\n\r\nWe fix this by:\r\n- removing the descriptors unused in the vertex shader in the generic case\r\n- adding the remaining descriptors in the SSR version of the layout\r\n\r\nIn practice this only adds one UBO (for shadows). That UBO is actually\r\nnot even used in the SSR variants, but the (generic) vertex shader \r\nlayout has it, so it must be provided. WE do this by providing a\r\ndummy UBO, which will never be used anyways.\r\n\r\nIn addition, we add a check to matc which will make sure such mismatch\r\nwon't happen again.\r\n\r\n* Update filament/src/ds/SsrPassDescriptorSet.cpp\r\n\r\nCo-authored-by: Powei Feng <powei@google.com>\r\n\r\n---------\r\n\r\nCo-authored-by: Powei Feng <powei@google.com>","shortMessageHtmlLink":"fix fragment/vertex shader descriptor set layout mismatch (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2535353488\" data-permission-text=\"Title is private\" data-url=\"https://github.com/google/filament/issues/8140\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/google/filament/pull/8140/hovercard\" href=\"https://github.com/google/filament/pull/8140\">#8140</a>)"}},{"before":"a81ab6d881520c4c36ba4b5dfdccfe2fde04428c","after":"130b6e9181687ab810fabad5f7301d368bcebd2c","ref":"refs/heads/ma/fix-descriptor-set-layout-mismatch","pushedAt":"2024-09-19T18:25:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pixelflinger","name":"Mathias Agopian","path":"/pixelflinger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1240896?s=80&v=4"},"commit":{"message":"Update filament/src/ds/SsrPassDescriptorSet.cpp\n\nCo-authored-by: Powei Feng <powei@google.com>","shortMessageHtmlLink":"Update filament/src/ds/SsrPassDescriptorSet.cpp"}},{"before":null,"after":"fad81e359b85635b384991e7b90e3fc8edc5f160","ref":"refs/heads/ma/fix-material-fixup","pushedAt":"2024-09-19T18:23:09.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"pixelflinger","name":"Mathias Agopian","path":"/pixelflinger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1240896?s=80&v=4"},"commit":{"message":"better fix for fixing up missing samplers\n\nthe previous fix prevented \"commit\" to patch the samplers\nthat use a texture with a volatile handle.\n\nthe proper fix is to patch them first, and then see if some are still\nmissing, in which case we use a dummy texture.","shortMessageHtmlLink":"better fix for fixing up missing samplers"}},{"before":"947e856bb85fd0d739342aa20458d603b9fd5ed3","after":"936e7e28f6740a3c42031c892bdbe0fb74f18395","ref":"refs/heads/pf/make-windows-build-faster","pushedAt":"2024-09-19T18:22:58.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"poweifeng","name":"Powei Feng","path":"/poweifeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/48371888?s=80&v=4"},"commit":{"message":"github: make windows build use all available cores","shortMessageHtmlLink":"github: make windows build use all available cores"}},{"before":null,"after":"947e856bb85fd0d739342aa20458d603b9fd5ed3","ref":"refs/heads/pf/make-windows-build-faster","pushedAt":"2024-09-19T18:08:36.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"poweifeng","name":"Powei Feng","path":"/poweifeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/48371888?s=80&v=4"},"commit":{"message":"github: make windows build use all available cores","shortMessageHtmlLink":"github: make windows build use all available cores"}},{"before":"3c537cb971e5ebbd663d00e6492e6c07f7a3ab27","after":"e34f6e43383d03cd12fcef8ede5d32c99e45db84","ref":"refs/heads/pf/fixup-for-mutable-textures","pushedAt":"2024-09-19T16:48:30.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"poweifeng","name":"Powei Feng","path":"/poweifeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/48371888?s=80&v=4"},"commit":{"message":"Move missing sampler fixup to MaterialInstance::commit()\n\nSome texture handles are only known by commit() time, and so we\ndelay until right before committing the descriptor set to do the\nfixup.\n\nAdditionally, we print out warnings in use() so that users can\ntake care of actually settings textures on materials.","shortMessageHtmlLink":"Move missing sampler fixup to MaterialInstance::commit()"}},{"before":"b02ffbfad09ce0107cb5a547b471c6807e0e430e","after":"3c537cb971e5ebbd663d00e6492e6c07f7a3ab27","ref":"refs/heads/pf/fixup-for-mutable-textures","pushedAt":"2024-09-19T16:40:33.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"poweifeng","name":"Powei Feng","path":"/poweifeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/48371888?s=80&v=4"},"commit":{"message":"Move missing sampler fixup to MaterialInstance::commit()\n\nSome texture handles are only known by commit() time, and so we\ndelay until right before committing the descriptor set to do the\nfixup.\n\nAdditionally, we print out warnings in use() so that users can\ntake care of actually settings textures on materials.","shortMessageHtmlLink":"Move missing sampler fixup to MaterialInstance::commit()"}},{"before":null,"after":"a81ab6d881520c4c36ba4b5dfdccfe2fde04428c","ref":"refs/heads/ma/fix-descriptor-set-layout-mismatch","pushedAt":"2024-09-19T05:51:26.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"pixelflinger","name":"Mathias Agopian","path":"/pixelflinger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1240896?s=80&v=4"},"commit":{"message":"fix fragment/vertex shader descriptor set layout mismatch\n\nThe SSR variant uses a custom fragment shader but the generic vertex\nshader. For this reason their descriptor set layout for the \"per view\"\nset end-up being different (the fragment shader one has less\ndescriptors in it and the descriptor itself is create from the SSR\nvariant data).  In the end, we end up with a descriptor set that's too\nsmall for the vertex shader and Metal was rightly complaining.\n\nWe fix this by:\n- removing the descriptors unused in the vertex shader in the generic case\n- adding the remaining descriptors in the SSR version of the layout\n\nIn practice this only adds one UBO (for shadows). That UBO is actually\nnot even used in the SSR variants, but the (generic) vertex shader \nlayout has it, so it must be provided. WE do this by providing a\ndummy UBO, which will never be used anyways.\n\nIn addition, we add a check to matc which will make sure such mismatch\nwon't happen again.","shortMessageHtmlLink":"fix fragment/vertex shader descriptor set layout mismatch"}},{"before":"c5a48e23ab0b0b2bbaaed2cd360cd3251b084a71","after":null,"ref":"refs/heads/pf/github-continuous-release-upgrade","pushedAt":"2024-09-19T05:36:52.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"poweifeng","name":"Powei Feng","path":"/poweifeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/48371888?s=80&v=4"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0yMFQyMzowNzozOS4wMDAwMDBazwAAAAS8biV9","startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0yMFQyMzowNzozOS4wMDAwMDBazwAAAAS8biV9","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xOVQwNTozNjo1Mi4wMDAwMDBazwAAAAS6cWki"}},"title":"Activity · google/filament"}