-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Traces and Profiles missing extraConfig block #565
Comments
Good to see you are working on this! Is it possible to Cherry pick the fix and merge this already? Currently we are working around this "bug" by patching the configmap after deployment. It would be great if we can leverage your fix without having to patch our helm chart locally. |
Currently we have: extraConfig: ... # Adds config to the "alloy" instance
logs:
extraConfig: ... # Adds config to the "alloy-logs" instance
cluster_events:
extraConfig: ... # Adds config to the "alloy-events" instance
journal:
extraConfig: ... # Not used anywhere currently We could add: profiles:
extraConfig: ... # Adds config to the "alloy-profiles" instance Trace receivers exist on the alloy instance, so the top-level |
So, a few options:
profiles:
extraConfig: ... # Adds config to the "alloy-profiles" instance
alloy:
extraConfig: ...
alloy-events:
extraConfig: ...
alloy-logs:
extraConfig: ...
alloy-profiles:
extraConfig: ... |
My thoughts as a user:
Afterburner: is there a reason |
Let me chat with some folks internally and we'll make a plan.
Because the "main" alloy instance scrapes metrics, but also opens the receivers, which then can pick up traces, as well as metrics and logs pushed via OTLP, OTLP HTTP, Zipkin, Jaeger, etc... It mostly does metrics, but it can do much more than just metrics. |
I assume it's easiest and least intrusive to just merge adding the |
I now see that you merged another way to configure Profiles. I've got my usecase to work with the helm values below. Please disregard my comment above, thank you!
|
Add support for traces and profiles
extraConfig
block.The text was updated successfully, but these errors were encountered: