Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PodLogs CRDs are being disabled. #567

Open
bentonam opened this issue Jun 10, 2024 · 1 comment
Open

PodLogs CRDs are being disabled. #567

bentonam opened this issue Jun 10, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@bentonam
Copy link
Collaborator

The comment values.yaml#L2059

# Skip installation of the Grafana Alloy CRDs, since we don't use them in this chart

Is incorrect, the crds chart deploys the PodLogs object https://github.com/grafana/alloy/tree/main/operations/helm/charts/alloy/charts/crds which is supported by this chart and may need to be enabled in some situations if the PodLogs CRD is being used.

@bentonam bentonam added the bug Something isn't working label Jun 10, 2024
@petewall
Copy link
Collaborator

Yeah, the comment could be improved. Maybe we should say something along the lines of:

"Alloy CRDs are disabled by default, but can be enabled to deploy the definitions for PodLogs objects"

I don't want to enable them by default because we've run into too much trouble with the operator CRDs and upgrade conflicts, deployments with things like ArgoCD, etc...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants