Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define icon to use in browser checks group card #884

Open
VikaCep opened this issue Jul 23, 2024 · 2 comments
Open

Define icon to use in browser checks group card #884

VikaCep opened this issue Jul 23, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request feature:browser frontend Needs to be implemented in the frontend application help wanted: design

Comments

@VikaCep
Copy link
Contributor

VikaCep commented Jul 23, 2024

Browser checks are using this icon. We should define whether we want to keep it or add a new one.

Screenshot of the Browser card on the Choose a check type page. It shows a thick-lined globe icon at the top of the card.

Originally posted by @ckbedwell in #862 (comment)

@VikaCep VikaCep self-assigned this Jul 23, 2024
@VikaCep VikaCep added enhancement New feature or request frontend Needs to be implemented in the frontend application labels Jul 24, 2024
@majavojnoska majavojnoska self-assigned this Aug 14, 2024
@VikaCep
Copy link
Contributor Author

VikaCep commented Aug 16, 2024

@majavojnoska I've been thinking on what icon to use for the new browser check group type. Here are a few options but I could really use your input/suggestions.

  • globe (existing icon)
    image

  • monitor (existing icon)
    image

  • browser (we have to add it. docs on how to add a new icon)
    image

  • a different one?

For reference, the list of icons that we have available today https://developers.grafana.com/ui/latest/index.html?path=/story/docs-overview-icon--icons-overview

@majavojnoska
Copy link

None of these look good. And when I look into the other check types, none have the same line weight either. I'll try something custom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature:browser frontend Needs to be implemented in the frontend application help wanted: design
Projects
None yet
Development

No branches or pull requests

3 participants