Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom exceptions should inherit from StandardError not Exception #1

Open
masterkain opened this issue May 13, 2012 · 2 comments
Open

Custom exceptions should inherit from StandardError not Exception #1

masterkain opened this issue May 13, 2012 · 2 comments

Comments

@masterkain
Copy link

Exception is too high level in the tree: http://whynotwiki.com/Ruby_/_Exception_handling#Exception_hierarchy

Currently when rescuing exceptions thrown by musix_match with rescue => ex will not trap anything.
@gravityblast
Copy link
Owner

Yes, I think the best way is to change all the custom exception and make them inherit from StandardError. what do you think?

@gravityblast
Copy link
Owner

you told me that in the title, I replied just after reading the body :) feel free to send me a pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gravityblast @masterkain