Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #17 #87

Open
alanjds opened this issue Oct 6, 2018 · 5 comments
Open

fix for #17 #87

alanjds opened this issue Oct 6, 2018 · 5 comments
Labels
imported PR Pull Request imported from google/grumpy waiting feedback Waiting confirmation of changes or fixes

Comments

@alanjds
Copy link

alanjds commented Oct 6, 2018

google#265 opened on Mar 6, 2017 by @jamdagni86

This is something which I could come up with in a couple of hours. The idea is to merge the constituent tuple arguments into a single argument (by joining argument names with τ) and get them unpacked inside the function using array notation.

Let me know your thoughts on the same. Unit tests are still work in progress; will update the PR once they are ready!

@alanjds
Copy link
Author

alanjds commented Oct 6, 2018

Comment by googlebot
Monday Mar 06, 2017 at 19:35 GMT


Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@alanjds
Copy link
Author

alanjds commented Oct 6, 2018

Comment by jamdagni86
Monday Mar 06, 2017 at 19:40 GMT


I signed it!

@alanjds
Copy link
Author

alanjds commented Oct 6, 2018

Comment by googlebot
Monday Mar 06, 2017 at 19:40 GMT


CLAs look good, thanks!

@alanjds
Copy link
Author

alanjds commented Oct 6, 2018

Comment by jamdagni86
Wednesday Aug 30, 2017 at 06:38 GMT


@trotterdylan - The build is failing in go 1.9 as mentioned in google#378

@alanjds alanjds added the imported PR Pull Request imported from google/grumpy label Oct 6, 2018
@alanjds alanjds added the waiting feedback Waiting confirmation of changes or fixes label Oct 6, 2018
@alanjds
Copy link
Author

alanjds commented Oct 6, 2018

@jamdagni86: I think we fixed the compilation issues. Please let me know if you think this (google#265) is good to merge, in your opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imported PR Pull Request imported from google/grumpy waiting feedback Waiting confirmation of changes or fixes
Projects
None yet
Development

No branches or pull requests

1 participant