Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "Closed" status #55

Open
tswfi opened this issue Jan 13, 2023 · 2 comments
Open

Implement "Closed" status #55

tswfi opened this issue Jan 13, 2023 · 2 comments

Comments

@tswfi
Copy link
Member

tswfi commented Jan 13, 2023

To keep some history of closed hacklabs implement new "closed" status for hacklab information

Currently accepted states are active, building, idea, restructuring (see here: https://github.com/hacklab-fi/hacklab-website/blob/master/_includes/cities.html#L4). At least one more status closed is needed. (see pr: #54 )

@janilahti
Copy link

Should closed be shown on the lab list or is the status only for storing the historical data?

@olmari
Copy link
Member

olmari commented Jan 14, 2023

Mostly matter of preferences... I'd say optimally there should be something shown for peoples looking around, but then again for how long etc... In the other hand if we only want to have no data anyway then we don't need "closed" status but just delete things out... So in that sense actual status should have some info shown on site...

tswfi added a commit that referenced this issue Jan 25, 2023
Closed status is not yet really implemented (see issue #55) but as closed is not a valid status at the moment it wont show on the page.
tswfi added a commit that referenced this issue Jan 25, 2023
Closed status is not yet really implemented (see issue #55) but as closed is not a valid status at the moment it wont show on the page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants