Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Remove unused explicit imports from modules that (may) have side-effects #183

Open
Avasam opened this issue Dec 8, 2022 · 0 comments
Labels
enhancement New feature or request feature New things

Comments

@Avasam
Copy link
Contributor

Avasam commented Dec 8, 2022

Describe the solution you'd like A clear and concise description of what you want to
happen.

If side-effects cannot be analysed (or are analyzed as "maybe"), could pycln still remove unused explicit imports?
ie:

from c_module import used, unused
# to
from c_module import used


from c_module import unused
# to
import c_module

Describe alternatives you've considered A clear and concise description of any
alternative solutions or features you've considered.

For now I # nopycln: import those lines (and/or add the c-modules to the exclude list).

Additional context Add any other context or screenshots about the feature request
here.

Came from the following comments: #182 (comment)

@Avasam Avasam added enhancement New feature or request feature New things labels Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature New things
Projects
None yet
Development

No branches or pull requests

1 participant