Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server.extraLabels missing on statefulset #911

Open
hameno opened this issue Jun 13, 2023 · 1 comment
Open

server.extraLabels missing on statefulset #911

hameno opened this issue Jun 13, 2023 · 1 comment
Labels
enhancement New feature or request vault-server Area: operation and usage of vault server in k8s

Comments

@hameno
Copy link

hameno commented Jun 13, 2023

Describe the bug
Setting server.extraLabels only applies labels to pods and not to the statefulset itself.

To Reproduce
Steps to reproduce the behavior:

  1. Install chart with server.extraLabels set
  2. Look at statefulset

Expected behavior
Labels should be applied to the statefulset

Environment

  • Kubernetes version: EKS 1.24
    • Distribution or cloud vendor (OpenShift, EKS, GKE, AKS, etc.):
    • Other configuration options or runtime services (istio, etc.):
  • vault-helm version: 0.24.1

Chart values:

# Paste your user-supplied values here (`helm get values <release>`).
# Be sure to scrub any sensitive values!
server:
  extraLabels:
    tags.datadoghq.com/service: vault

Additional context
We're setting up Datadog and the statefulset should be labelled aswell.

@hameno hameno added the bug Something isn't working label Jun 13, 2023
@tvoran tvoran added enhancement New feature or request vault-server Area: operation and usage of vault server in k8s and removed bug Something isn't working labels Jun 17, 2023
@bmeverett
Copy link

Any update on this? Looks like this was implemented in #680 but seems to have stalled.

Seems #992 was reported to add this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vault-server Area: operation and usage of vault server in k8s
Projects
None yet
Development

No branches or pull requests

3 participants