Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling resource limits by default in agent injector #484

Open
mprasil opened this issue May 31, 2023 · 0 comments
Open

Allow disabling resource limits by default in agent injector #484

mprasil opened this issue May 31, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@mprasil
Copy link

mprasil commented May 31, 2023

Is your feature request related to a problem? Please describe.

#174 allows to not add resource limits to the injected container by providing empty string as value in relevant annotation. However when trying to set this as default via environment variable (for example using AGENT_INJECT_CPU_LIMIT) this does not work as environment variable with empty string value is ignored and default is used instead.

Describe the solution you'd like

Either empty string is accepted as value and then same mechanism will apply as for annotation with empty string or some other value like none is used for the same purpose.

Describe alternatives you've considered

This is primary mechanism the vault helm chat is using to set the default values, so there aren't really any alternatives other than adding the vault.hashicorp.com/agent-limits-cpu: "" annotation to every deployment, which is quite cumbersome.

@mprasil mprasil added the enhancement New feature or request label May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant