Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of the init/sidecar container names globally #540

Open
dtrts opened this issue Oct 26, 2023 · 1 comment
Open

Allow configuration of the init/sidecar container names globally #540

dtrts opened this issue Oct 26, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@dtrts
Copy link

dtrts commented Oct 26, 2023

Is your feature request related to a problem? Please describe.

I'm currently in an environment where two vault-agents will be running simultaneously. The current set up has the agents selecting mutually exclusive pods. As part of development work within the k8s cluster it is not obvious which agent was responsible for the init/sidecard containers in the target pods. This is because the container names are hardcoded within the agent.

There is an option to use a json-patch annotation to rename the containers. However this is done on the pod and would have the same effect on the containers regardless of which agent was injecting them.

If for some reason a pod was selected by multiple agents this would also prevent name clashes of containers within the pod. (I'm not sure this would even work!)

Describe the solution you'd like
A configuration option for the container names defined here and here which can be set globally and thus confidently reveal the agent which triggered the injection.

Describe alternatives you've considered
I have been active in a closed issue which appears to be requesting the same feature: #290

This issue was closed with a redirect provided to this PR: #291

As mentioned on the other thread this did not resolve my problem in the way I expected.

@dtrts dtrts added the enhancement New feature or request label Oct 26, 2023
@dtrts
Copy link
Author

dtrts commented Oct 26, 2023

cc. @tomhjp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant